2014-04-01 13:29:10

by Tushar Behera

[permalink] [raw]
Subject: Re: [PATCH 2/2] regulator: core: Add reg_ignore_unused to keep boot time regulators enabled

On 28 March 2014 15:52, Mark Brown <[email protected]> wrote:
> On Fri, Mar 28, 2014 at 10:50:22AM +0530, Tushar Behera wrote:
>> Keep all regulators already enabled by bootloader on, even if no
>> driver has claimed them. This is useful for debug and development, but
>> should not be needed on a platform with proper driver support.
>
> That's already the default on non-DT systems so I'd expect that if we
> were doing this the code would be joined up with the code for that. I'm
> not sure this is a terribly good idea though - we already display a
> message just before we power off the regulator and having an option like
> this feels like it's going to encourage people to write bad DTs and tell
> people to add this to their command line.

I agree with your point that it may lead developers to write bad DTs,
but it becomes quite helpful while debugging issues.

--
Tushar Behera


2014-04-01 15:58:34

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 2/2] regulator: core: Add reg_ignore_unused to keep boot time regulators enabled

On Tue, Apr 01, 2014 at 06:59:04PM +0530, Tushar Behera wrote:

> I agree with your point that it may lead developers to write bad DTs,
> but it becomes quite helpful while debugging issues.

So make what you're trying to do look more like a debug option then...
though to be honest given how easy things are to resolve and the prints
that are there already I'm not sure it's that helpful.


Attachments:
(No filename) (390.00 B)
signature.asc (836.00 B)
Digital signature
Download all attachments