2020-09-01 16:03:09

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH v2] iio: sx9310: Prefer async probe

Quoting Douglas Anderson (2020-09-01 08:19:43)
> On one board I found that:
> probe of 5-0028 returned 1 after 259547 usecs
>
> While some of this time is attributable to the pile of i2c transfers
> that we do at probe time, the lion's share (over 200 ms) is sitting
> waiting in the polling loop in sx9310_init_compensation() waiting for
> the hardware to indicate that it's done.
>
> There's no reason to block probe of all other devices on our probe.
> Turn on async probe.
>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>


2020-09-01 17:05:43

by Daniel Campello

[permalink] [raw]
Subject: Re: [PATCH v2] iio: sx9310: Prefer async probe

On Tue, Sep 1, 2020 at 9:43 AM Stephen Boyd <[email protected]> wrote:
>
> Quoting Douglas Anderson (2020-09-01 08:19:43)
> > On one board I found that:
> > probe of 5-0028 returned 1 after 259547 usecs
> >
> > While some of this time is attributable to the pile of i2c transfers
> > that we do at probe time, the lion's share (over 200 ms) is sitting
> > waiting in the polling loop in sx9310_init_compensation() waiting for
> > the hardware to indicate that it's done.
> >
> > There's no reason to block probe of all other devices on our probe.
> > Turn on async probe.
> >
> > Signed-off-by: Douglas Anderson <[email protected]>
> > ---
>
> Reviewed-by: Stephen Boyd <[email protected]>

Reviewed-by: Daniel Campello <[email protected]>

2020-09-06 15:27:05

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH v2] iio: sx9310: Prefer async probe

On Tue, 1 Sep 2020 11:01:29 -0600
Daniel Campello <[email protected]> wrote:

> On Tue, Sep 1, 2020 at 9:43 AM Stephen Boyd <[email protected]> wrote:
> >
> > Quoting Douglas Anderson (2020-09-01 08:19:43)
> > > On one board I found that:
> > > probe of 5-0028 returned 1 after 259547 usecs
> > >
> > > While some of this time is attributable to the pile of i2c transfers
> > > that we do at probe time, the lion's share (over 200 ms) is sitting
> > > waiting in the polling loop in sx9310_init_compensation() waiting for
> > > the hardware to indicate that it's done.
> > >
> > > There's no reason to block probe of all other devices on our probe.
> > > Turn on async probe.
> > >
> > > Signed-off-by: Douglas Anderson <[email protected]>
> > > ---
> >
> > Reviewed-by: Stephen Boyd <[email protected]>
>
> Reviewed-by: Daniel Campello <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at it.

thanks,

Jonathan