2012-06-03 06:24:43

by devendra.aaru

[permalink] [raw]
Subject: [PATCH] rtc/rtc-spear: free the config right after the rtc_device_unregister

the config was freed and its used again at rtc_device_unregister which leads
to a kernel panic. so, do it right after the rtc_device_unregister

Signed-off-by: Devendra Naga <[email protected]>
---
drivers/rtc/rtc-spear.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c
index 1f76320..e278547 100644
--- a/drivers/rtc/rtc-spear.c
+++ b/drivers/rtc/rtc-spear.c
@@ -458,12 +458,12 @@ static int __devexit spear_rtc_remove(struct platform_device *pdev)
clk_disable(config->clk);
clk_put(config->clk);
iounmap(config->ioaddr);
- kfree(config);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (res)
release_mem_region(res->start, resource_size(res));
platform_set_drvdata(pdev, NULL);
rtc_device_unregister(config->rtc);
+ kfree(config);

return 0;
}
--
1.7.9.5


2012-06-20 14:39:23

by devendra.aaru

[permalink] [raw]
Subject: Re: [PATCH] rtc/rtc-spear: free the config right after the rtc_device_unregister

Hi Viresh,

On Wed, Jun 20, 2012 at 7:57 PM, Viresh Kumar <[email protected]> wrote:
> Reviewed-by: Viresh Kumar <[email protected]>

Thanks, at last :-).

Is there any tree through which it can reach torvalds?

Thanks,
Devendra.

2012-06-20 14:44:57

by viresh kumar

[permalink] [raw]
Subject: Re: [PATCH] rtc/rtc-spear: free the config right after the rtc_device_unregister

On Wed, Jun 20, 2012 at 3:39 PM, devendra.aaru <[email protected]> wrote:
> On Wed, Jun 20, 2012 at 7:57 PM, Viresh Kumar <[email protected]> wrote:
>> Reviewed-by: Viresh Kumar <[email protected]>
>
> Thanks, at last :-).
>
> Is there any tree through which it can reach torvalds?

The way I would have found this information about any driver is by
looking at its
git-log and check via which path patches have been going till date. Maintainers
normally adds there signed-off's to patches that go through them.

Andrew Morton, is the one who applied rtc-spear patches till now. Added in cc.

--
viresh

2012-06-20 16:49:56

by devendra.aaru

[permalink] [raw]
Subject: Re: [PATCH] rtc/rtc-spear: free the config right after the rtc_device_unregister

Hi Viresh,

On Wed, Jun 20, 2012 at 8:14 PM, viresh kumar <[email protected]> wrote:
> On Wed, Jun 20, 2012 at 3:39 PM, devendra.aaru <[email protected]> wrote:
>> On Wed, Jun 20, 2012 at 7:57 PM, Viresh Kumar <[email protected]> wrote:
>>> Reviewed-by: Viresh Kumar <[email protected]>
>>
>> Thanks, at last :-).
>>
>> Is there any tree through which it can reach torvalds?
>
> The way I would have found this information about any driver is by
> looking at its
> git-log and check via which path patches have been going till date. Maintainers
> normally adds there signed-off's to patches that go through them.
>
> Andrew Morton, is the one who applied rtc-spear patches till now. Added in cc.
>
Thanks a lot for the information.
> --
> viresh

Devendra.