2012-08-26 09:05:01

by Fengguang Wu

Subject: fs/ntfs/super.c:2717:1-14: alloc with no test

Hi Anton,

FYI, coccinelle warns about

fs/ntfs/super.c:2717:1-14: alloc with no test, possible model on line 2718

vim +2717 fs/ntfs/super.c
2714 sb->s_flags |= MS_RDONLY;
2715 #endif /* ! NTFS_RW */
2716 /* Allocate a new ntfs_volume and place it in sb->s_fs_info. */
> 2717 sb->s_fs_info = kmalloc(sizeof(ntfs_volume), GFP_NOFS);
2718 vol = NTFS_SB(sb);
2719 if (!vol) {
2720 if (!silent)

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

2012-08-26 09:12:15

by devendra.aaru

Subject: Re: fs/ntfs/super.c:2717:1-14: alloc with no test

On Sun, Aug 26, 2012 at 2:34 PM, Fengguang Wu <[email protected]> wrote:
>
> Hi Anton,
>
> FYI, coccinelle warns about
>
> fs/ntfs/super.c:2717:1-14: alloc with no test, possible model on line 2718
>
> vim +2717 fs/ntfs/super.c
> 2714 sb->s_flags |= MS_RDONLY;
> 2715 #endif /* ! NTFS_RW */
> 2716 /* Allocate a new ntfs_volume and place it in sb->s_fs_info. */
>> 2717 sb->s_fs_info = kmalloc(sizeof(ntfs_volume), GFP_NOFS);

That's i think a false alarm.

> 2718 vol = NTFS_SB(sb);

The NTFS_SB(buf) {
buf->s_fs_info;
}

so we are validating the allocated pointer s_fs_info.

correct me if i am wrong.

Thanks,

> 2719 if (!vol) {
> 2720 if (!silent)
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Centre
> Fengguang Wu <[email protected]> Intel Corporation
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2012-08-26 09:31:21

by Fengguang Wu

Subject: Re: fs/ntfs/super.c:2717:1-14: alloc with no test

On Sun, Aug 26, 2012 at 02:42:12PM +0530, devendra.aaru wrote:
> On Sun, Aug 26, 2012 at 2:34 PM, Fengguang Wu <[email protected]> wrote:
> >
> > Hi Anton,
> >
> > FYI, coccinelle warns about
> >
> > fs/ntfs/super.c:2717:1-14: alloc with no test, possible model on line 2718
> >
> > vim +2717 fs/ntfs/super.c
> > 2714 sb->s_flags |= MS_RDONLY;
> > 2715 #endif /* ! NTFS_RW */
> > 2716 /* Allocate a new ntfs_volume and place it in sb->s_fs_info. */
> >> 2717 sb->s_fs_info = kmalloc(sizeof(ntfs_volume), GFP_NOFS);
>
> That's i think a false alarm.
>
> > 2718 vol = NTFS_SB(sb);
>
> The NTFS_SB(buf) {
> buf->s_fs_info;
> }
>
> so we are validating the allocated pointer s_fs_info.

Yes, it is. Sorry for the noise!

Thanks,
Fengguang