2014-02-07 09:34:58

by Naveen Krishna Ch

[permalink] [raw]
Subject: Re: [PATCH v12 3/4] thermal: samsung: Add TMU support for Exynos5420 SoCs

Hello All,

On 19 December 2013 17:04, Tomasz Figa <[email protected]> wrote:
> On Thursday 19 of December 2013 11:36:31 Naveen Krishna Chatradhi wrote:
>> Exynos5420 has 5 TMU channels, the TRIMINFO register is
>> misplaced for TMU channels 2, 3 and 4
>> TRIMINFO at 0x1006c000 contains data for TMU channel 3
>> TRIMINFO at 0x100a0000 contains data for TMU channel 4
>> TRIMINFO at 0x10068000 contains data for TMU channel 2
>>
>> This patch
>> 1 Adds the neccessary register changes and arch information
>> to support Exynos5420 SoCs.
>> 2. Handles the gate clock for misplaced TRIMINFO register
>> 3. Updates the Documentation at
>> Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>>
>> Signed-off-by: Naveen Krishna Chatradhi <[email protected]>
>> Signed-off-by: Andrew Bresticker <[email protected]>
>> Acked-by: Amit Daniel Kachhap <[email protected]>
>> Reviewed-by: Bartlomiej Zolnierkiewicz <[email protected]>
>> ---
>> Changes since v11:
>> 1. Added description for clocks in the Documentation
>> 2. corrected the clock name in clk_get() function as per description
>>
>> Changes since v10:
>> 1. using renamed compatible "samsung,exynos5420-tmu-ext-triminfo"
>> and passing same clock as triminfo_apbif clock for channel 2
>> 2. removed the "exynos5420-tmu-triminfo-clk" compatible
>> .../devicetree/bindings/thermal/exynos-thermal.txt | 45 ++++++++-
>> drivers/thermal/samsung/exynos_tmu.c | 52 +++++++++-
>> drivers/thermal/samsung/exynos_tmu.h | 1 +
>> drivers/thermal/samsung/exynos_tmu_data.c | 99 ++++++++++++++++++++
>> drivers/thermal/samsung/exynos_tmu_data.h | 8 ++
>> 5 files changed, 200 insertions(+), 5 deletions(-)
>
> Reviewed-by: Tomasz Figa <[email protected]>
>
> Best regards,
> Tomasz
>
Ping.



--
Shine bright,
(: Nav :)