So this goes out on Monday morning rather than my usual Sunday
afternoon schedule, simply because I was away from a keyboard most of
Sunday. It happens.
Partly because of that, I got a couple of pull requests (networking,
usb, misc/char) that would have missed this rc with the normal timing,
and it's a bit bigger as a result. Not huge, but considering how quiet
the beginning of the week was, it's definitely noticeable, and the one
extra day added about 25% to the size of the rc.
That's not enough for me to go "uhhuh, uncomfortably much this late in
the rc game" but I also happened to look at the calendar last week,
and it dawned on me that I have the kernel summit travel coming up,
and if I do the usual release cadence, I'd be on the road during the
worst time (for me) of the merge window - the first five days.
So I do suspect that with my timing (and a number of other developers
are probably going to be traveling for LPC and KS too) I'll just make
an rc8 even if it turns this Labor Day week ends up being very quiet
and there might not be any _technical_ reason to delay the release.
NOTE! If you are a submaintainer, and have your pull request all ready
to go for 5.4, you should - as always - feel free to just send it
early. I already have one 5.4 pull request in my inbox, and I much
prefer the early ones over the late ones. So if you were planning for
the normal cadence, just go on with your life, and ignore the likely
one-week release delay due to conference travel.
As to what happened in rc7 itself: the shortlog is appended, and
nothing huge stands out. The diffstat is mostly fairly flat, which
means it's a lot of small changes, with just a few blips: rxpc,
openvswitch, cifssmb cleanups, turbostat utility update, and some
embargoed hw issue process documentation.
But the bulk of it is small fixes all over: drivers, networking, arch
updates, documentation, filesystems..
Would I have been happier with things being even calmer? Sure. But it
all looks pretty normal.
So go forth and test,
Linus
---
Aaron Liu (1):
drm/amdgpu: fix GFXOFF on Picasso and Raven2
Alexander Shishkin (2):
intel_th: pci: Add support for another Lewisburg PCH
intel_th: pci: Add Tiger Lake support
Alexander Wetzel (1):
cfg80211: Fix Extended Key ID key install checks
Alexei Starovoitov (1):
bpf: fix precision tracking in presence of bpf2bpf calls
Alexey Brodkin (1):
ARCv2: entry: early return from exception need not clear U & DE bits
Alexey Kardashevskiy (1):
KVM: PPC: Book3S: Fix incorrect guest-to-user-translation error handling
Alexey Kodanev (1):
ipv4: mpls: fix mpls_xmit for iptunnel
Anders Roxell (2):
selftests/bpf: add config fragment BPF_JIT
selftests/bpf: install files test_xdp_vlan.sh
Andrew Cooks (1):
i2c: piix4: Fix port selection for AMD Family 16h Model 30h
Andrew Lunn (1):
MAINTAINERS: Add phylink keyword to SFF/SFP/SFP+ MODULE SUPPORT
Andrew Morton (1):
mm/zsmalloc.c: fix build when CONFIG_COMPACTION=n
Andy Shevchenko (1):
i2c: i801: Avoid memory leak in check_acpi_smo88xx_device()
Antoine Tenart (1):
net: cpsw: fix NULL pointer exception in the probe error path
Anup Patel (1):
RISC-V: Fix FIXMAP area corruption on RV32 systems
Arnd Bergmann (1):
mfd: rk808: Mark pm functions __maybe_unused
Artem Bityutskiy (2):
tools/power turbostat: read from pipes too
tools/power turbostat: do not enforce 1ms
Ayan Kumar Halder (1):
drm/komeda: Reordered the komeda's de-init functions
Bandan Das (2):
x86/apic: Do not initialize LDR and DFR for bigsmp
x86/apic: Include the LDR when clearing out APIC registers
Ben Hutchings (2):
tools/power x86_energy_perf_policy: Fix "uninitialized variable"
warnings at -O2
tools/power/x86: Enable compiler optimisations and Fortify by default
Bernard Metzler (1):
RDMA/siw: Fix IPv6 addr_list locking
Chen-Yu Tsai (1):
net: stmmac: dwmac-rk: Don't fail if phy regulator is absent
Christian König (1):
drm/amdgpu: fix dma_fence_wait without reference
Christophe JAILLET (3):
Kconfig: Fix the reference to the IDT77105 Phy driver in the
description of ATM_NICSTAR_USE_IDT77105
enetc: Add missing call to 'pci_free_irq_vectors()' in probe and
remove functions
net: seeq: Fix the function used to release some memory in an
error handling path
Chunyan Zhang (5):
mmc: sdhci-sprd: fixed incorrect clock divider
mmc: sdhci-sprd: add get_ro hook function
mmc: sdhci-sprd: add SDHCI_QUIRK2_PRESET_VALUE_BROKEN
mms: sdhci-sprd: add SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-sprd: clear the UHS-I modes read from registers
Colin Ian King (3):
net: ieee802154: remove redundant assignment to rc
typec: tcpm: fix a typo in the comparison of pdo_max_voltage
tools/power turbostat: fix leak of file descriptor on error return path
Cong Wang (1):
net_sched: fix a NULL pointer deref in ipt action
Dan Carpenter (2):
gve: Copy and paste bug in gve_get_stats()
cifs: Use kzfree() to zero out the password
Daniel Borkmann (1):
bpf: fix use after free in prog symbol exposure
David Ahern (1):
nexthop: Fix nexthop_num_path for blackhole nexthops
David Howells (8):
rxrpc: Improve jumbo packet counting
rxrpc: Use info in skbuff instead of reparsing a jumbo packet
rxrpc: Pass the input handler's data skb reference to the Rx ring
rxrpc: Abstract out rxtx ring cleanup
rxrpc: Add a private skb flag to indicate transmission-phase skbs
rxrpc: Use the tx-phase skb flag to simplify tracing
rxrpc: Use skb_unshare() rather than skb_cow_data()
rxrpc: Fix lack of conn cleanup when local endpoint is cleaned up [ver #2]
Davide Caratti (3):
net/sched: pfifo_fast: fix wrong dereference when qdisc is reset
net/sched: pfifo_fast: fix wrong dereference in pfifo_fast_enqueue
tc-testing: don't hardcode 'ip' in nsPlugin.py
Denis Efremov (4):
MAINTAINERS: Remove IP MASQUERADING record
MAINTAINERS: net_failover: Fix typo in a filepath
MAINTAINERS: i2c mv64xxx: Update documentation path
tracing: Make exported ftrace_set_clr_event non-static
Denis Kenzior (2):
mac80211: Don't memset RXCB prior to PAE intercept
mac80211: Correctly set noencrypt for PAE frames
Ding Xiang (1):
stm class: Fix a double free of stm_source_device
Dmitry Bogdanov (4):
net: aquantia: fix removal of vlan 0
net: aquantia: fix limit of vlan filters
net: aquantia: reapply vlan filters on up
net: aquantia: fix out of memory condition on rx side
Dmitry Osipenko (1):
Revert "mmc: sdhci-tegra: drop ->get_ro() implementation"
Dmitry Safonov (1):
mailmap: add aliases for Dmitry Safonov
Doug Berger (1):
ARM: 8874/1: mm: only adjust sections of valid mm structures
Eddie James (1):
fsi: scom: Don't abort operations for minor errors
Emmanuel Grumbach (1):
iwlwifi: pcie: fix the byte count table format for 22560 devices
Emmanuel Vadot (1):
ARM: dts: am335x: Fix UARTs length
Eran Ben Elisha (2):
net/mlx5e: Add num bytes metadata to WQE info
net/mlx5e: Remove ethernet segment from dump WQE
Eric Biggers (1):
keys: ensure that ->match_free() is called in request_key_and_link()
Eric Dumazet (4):
batman-adv: fix uninit-value in batadv_netlink_get_ifindex()
tcp: make sure EPOLLOUT wont be missed
tcp: remove empty skb from write queue in error cases
mld: fix memory leak in mld_del_delrec()
Eugen Hristev (1):
mmc: sdhci-of-at91: add quirk for broken HS200
Eugeniy Paltsev (2):
ARC: fix typo in setup_dma_ops log message
ARC: [plat-hsdk]: allow to switch between AXI DMAC port configurations
Evan Quan (1):
drm/amd/powerplay: correct Vega20 dpm level related settings
Faiz Abbas (2):
ARM: dts: am57xx: Disable voltage switching for SD card
ARM: dts: dra74x: Fix iodelay configuration for mmc3
Feng Sun (1):
net: fix skb use after free in netpoll
Florian Fainelli (1):
net: dsa: bcm_sf2: Do not configure PHYLINK on CPU port
Florian Westphal (2):
netfilter: conntrack: make sysctls per-namespace again
netfilter: nf_flow_table: clear skb tstamp before xmit
Gary R Hook (1):
crypto: ccp - Ignore unconfigured CCP device on suspend/resume
Geert Uytterhoeven (2):
usb: host: xhci: rcar: Fix typo in compatible string matching
soc: ixp4xx: Protect IXP4xx SoC drivers by ARCH_IXP4XX || COMPILE_TEST
George McCollister (1):
net: dsa: microchip: fill regmap_config name
Gerd Hoffmann (2):
drm/qxl: get vga ioports
drm/virtio: use virtio_max_dma_size
Greg Kroah-Hartman (1):
MAINTAINERS: add entry for LICENSES and SPDX stuff
Greg Rose (1):
openvswitch: Properly set L4 keys on "later" IP fragments
Gustavo A. R. Silva (7):
ARC: unwind: Mark expected switch fall-throughs
ARM: OMAP: dma: Mark expected switch fall-throughs
usb: udc: lpc32xx: silence fall-through warning
ARC: unwind: Mark expected switch fall-through
nds32: Mark expected switch fall-throughs
mm/z3fold.c: fix lock/unlock imbalance in z3fold_page_isolate
tools/power turbostat: fix file descriptor leaks
Hangbin Liu (3):
ipv6/addrconf: allow adding multicast addr if IFA_F_MCAUTOJOIN is set
ipv4/icmp: fix rt dst dev null pointer dereference
xfrm/xfrm_policy: fix dst dev null pointer dereference in collect_md mode
Hayes Wang (2):
Revert "r8152: napi hangup fix after disconnect"
r8152: remove calling netif_napi_del
Heiner Kallweit (1):
Revert "r8169: remove not needed call to dma_sync_single_for_device"
Henk van der Laan (1):
usb-storage: Add new JMS567 revision to unusual_devs
Heyi Guo (1):
KVM: arm/arm64: vgic: Fix potential deadlock when ap_list is long
Hodaszi, Robert (1):
Revert "cfg80211: fix processing world regdomain when non modular"
Hsin-Yi Wang (1):
i2c: mediatek: disable zero-length transfers for mt8183
Igor Russkikh (1):
net: aquantia: linkstate irq should be oneshot
Ilan Peer (1):
iwlwifi: mvm: Allow multicast data frames only when associated
Ilya Dryomov (1):
rbd: restore zeroing past the overlap when reading from parent
Ilya Leoshkevich (6):
s390/bpf: fix lcgr instruction encoding
s390/bpf: use 32-bit index for tail calls
selftests/bpf: fix "bind{4, 6} deny specific IP & port" on s390
selftests/bpf: fix test_cgroup_storage on s390
selftests/bpf: fix test_btf_dump with O=
bpf: allow narrow loads of some sk_reuseport_md fields with offset > 0
Ivan Khoronzhuk (1):
xdp: unpin xdp umem pages in error path
Jakub Kicinski (1):
tracing: Correct kdoc formats
Jakub Sitnicki (1):
flow_dissector: Fix potential use-after-free on BPF_PROG_DETACH
Janusz Krzysztofik (1):
ARM: OMAP1: ams-delta-fiq: Fix missing irq_ack
Jarkko Nikula (1):
i2c: designware: Synchronize IRQs when unregistering slave client
Jason Baron (1):
net/smc: make sure EPOLLOUT is raised
Jeronimo Borque (1):
ALSA: hda - Fixes inverted Conexant GPIO mic mute led
Jia-Ju Bai (1):
libceph: don't call crypto_free_sync_skcipher() on a NULL tfm
Jiong Wang (1):
nfp: bpf: fix latency bug when updating stack index register
Jisheng Zhang (1):
ftrace/x86: Remove mcount() declaration
Johannes Berg (1):
mac80211: fix possible sta leak
John Fastabend (1):
net: route dump netlink NLM_F_MULTI flag missing
John Garry (5):
lib: logic_pio: Fix RCU usage
lib: logic_pio: Avoid possible overlap for unregistering regions
lib: logic_pio: Add logic_pio_unregister_range()
bus: hisi_lpc: Unregister logical PIO range to avoid potential
use-after-free
bus: hisi_lpc: Add .remove method to avoid driver unbind crash
John Hurley (2):
nfp: flower: prevent ingress block binds on internal ports
nfp: flower: handle neighbour events on internal ports
Josh Hunt (1):
perf/x86/intel: Restrict period on Nehalem
Julian Wiedmann (1):
s390/qeth: reject oversized SNMP requests
Juliana Rodrigueiro (1):
netfilter: xt_nfacct: Fix alignment mismatch in xt_nfacct_match_info
Justin Pettit (1):
openvswitch: Clear the L4 portion of the key for "later" fragments.
[email protected] (1):
net/ncsi: Fix the payload copying for the request coming from Netlink
Ka-Cheong Poon (1):
net/rds: Fix info leak in rds6_inc_info_copy()
Kai-Heng Feng (3):
drm/amdgpu: Add APTX quirk for Dell Latitude 5495
USB: storage: ums-realtek: Update module parameter description
for auto_delink_en
USB: storage: ums-realtek: Whitelist auto-delink support
Keerthy (1):
soc: ti: pm33xx: Fix static checker warnings
Kent Russell (2):
drm/powerplay: Fix Vega20 Average Power value v4
drm/powerplay: Fix Vega20 power reading again
Kim Phillips (1):
perf/x86/amd/ibs: Fix sample bias for dispatched micro-ops
Kirill A. Shutemov (1):
x86/boot/compressed/64: Fix missing initialization in
find_trampoline_placement()
Laurent Pinchart (1):
drm/omap: Fix port lookup for SDI output
Lee Jones (1):
mfd: rk808: Make PM function declaration static
Len Brown (4):
tools/power turbostat: remove duplicate pc10 column
tools/power turbostat: Fix Haswell Core systems
tools/power turbostat: rename has_hsw_msrs()
tools/power turbostat: update version number
Li RongQing (2):
net: fix __ip_mc_inc_group usage
net: fix icmp_socket_deliver argument 2 input
Linus Torvalds (3):
x86/build: Add -Wnoaddress-of-packed-member to REALMODE_CFLAGS,
to silence GCC9 build warning
Partially revert "kfifo: fix kfifo_alloc() and kfifo_init()"
Linux 5.3-rc7
Lori Hikichi (1):
i2c: iproc: Stop advertising support of SMBUS quick cmd
Luca Coelho (3):
iwlwifi: pcie: don't switch FW to qnj when ax201 is detected
iwlwifi: pcie: fix recognition of QuZ devices
iwlwifi: pcie: handle switching killer Qu B0 NICs to C0
Lukasz Majewski (1):
ARM: dts: vf610-bk4: Fix qspi node description
Lvqiang Huang (1):
ARM: 8897/1: check stmfd instruction using right shift
Lyude Paul (1):
drm/i915: Call dma_set_max_seg_size() in i915_driver_hw_probe()
Manasi Navare (1):
drm/i915/dp: Fix DSC enable code to use cpu_transcoder instead
of encoder->type
Marc Zyngier (2):
kallsyms: Don't let kallsyms_lookup_size_offset() fail on
retrieving the first symbol
KVM: arm/arm64: vgic-v2: Handle SGI bits in GICD_I{S,C}PENDR0 as WI
Marco Hartmann (1):
Add genphy_c45_config_aneg() function to phy-c45.c
Masahiro Yamada (2):
netfilter: add include guard to nf_conntrack_h323_types.h
mmc: sdhci-cadence: enable v4_mode to fix ADMA 64-bit addressing
Matt Lupfer (1):
tools/power: Fix typo in man page
Maxime Ripard (1):
MAINTAINERS: Update my email address
Michal Hocko (1):
mm, memcg: do not set reclaim_state on soft limit reclaim
Mihail Atanassov (1):
drm/komeda: Add missing of_node_get() call
Mike Rapoport (1):
trivial: netns: fix typo in 'struct net.passive' description
Mischa Jonker (3):
ARCv2: IDU-intc: Add support for edge-triggered interrupts
dt-bindings: IDU-intc: Clean up documentation
dt-bindings: IDU-intc: Add support for edge-triggered interrupts
Moshe Shemesh (2):
net/mlx5: Fix crdump chunks print
net/mlx5: Fix delay in fw fatal report handling due to fw report
Nadav Amit (2):
VMCI: Release resource if the work is already queued
vmw_balloon: Fix offline page marking with compaction
Nagarjuna Kristam (1):
usb: host: xhci-tegra: Set DMA mask correctly
Naoya Horiguchi (1):
tools/power turbostat: fix buffer overrun
Naveen N. Rao (3):
bpf: handle 32-bit zext during constant blinding
ftrace: Fix NULL pointer dereference in t_probe_next()
ftrace: Check for successful allocation of hash
Neil Armstrong (2):
arm64: dts: meson-g12a: add missing dwc2 phy-names
arm64: dts: meson-g12a-sei510: enable IR controller
Nick Desaulniers (1):
arc: prefer __section from compiler_attributes.h
Oliver Neukum (2):
usbtmc: more sanity checking for packet size
USB: cdc-wdm: fix race between write and disconnect due to flag abuse
Pablo Neira Ayuso (1):
netfilter: nft_flow_offload: missing netlink attribute policy
Paweł Rekowski (1):
ALSA: hda/ca0132 - Add new SBZ quirk
Peter Chen (1):
usb: chipidea: udc: don't do hardware access if gadget has stopped
Phil Reid (1):
fpga: altera-ps-spi: Fix getting of optional confd gpio
Prashant Malani (1):
r8152: Set memory to all 0xFFs on failed reg reads
Pu Wen (2):
tools/power turbostat: Fix caller parameter of get_tdp_amd()
tools/power turbostat: Add support for Hygon Fam 18h (Dhyana) RAPL
Quentin Monnet (1):
tools: bpftool: close prog FD before exit on showing a single program
Rajneesh Bhardwaj (1):
tools/power turbostat: Add Ice Lake NNPI support
Randy Dunlap (1):
mtd: hyperbus: fix dependency and build error
Raul E Rangel (1):
lkdtm/bugs: fix build error in lkdtm_EXHAUST_STACK
Razvan Stefanescu (2):
dt-bindings: net: dsa: document additional Microchip KSZ8563 switch
net: dsa: microchip: add KSZ8563 compatibility string
Roman Gushchin (2):
mm: memcontrol: flush percpu slab vmstats on kmem offlining
mm, memcg: partially revert "mm/memcontrol.c: keep local VM
counters in sync with the hierarchical ones"
Ronnie Sahlberg (2):
cifs: set domainName when a domain-key is used in multiuser
cifs: replace various strncpy with strscpy and similar
Ryan M. Collins (1):
net: bcmgenet: use ethtool_op_get_ts_info()
Sabrina Dubroca (1):
ipv6: propagate ipv6_add_dev's error returns out of ipv6_find_idev
Schmid, Carsten (1):
usb: hcd: use managed device resources
Sean Christopherson (1):
KVM: x86: Don't update RIP or do single-step on faulting emulation
Sebastian Mayr (1):
uprobes/x86: Fix detection of 32-bit user mode
Shakeel Butt (1):
mm: memcontrol: fix percpu vmstats and vmevents flush
Srinivas Pandruvada (1):
tools/power turbostat: Fix CPU%C1 display value
Stanislaw Gruszka (2):
mt76: mt76x0u: do not reset radio on resume
rt2x00: clear IV's on start to fix AP mode regression
Stefano Brivio (1):
ipv6: Fix return value of ipv6_mc_may_pull() for malformed packets
Steve French (1):
cifs: update internal module number
Steven Rostedt (VMware) (1):
ftrace: Check for empty hash and comment the race with registering probes
Suman Anna (1):
bus: ti-sysc: Simplify cleanup upon failures in sysc_probe()
Sven Eckelmann (2):
batman-adv: Only read OGM tvlv_len after buffer len check
batman-adv: Only read OGM2 tvlv_len after buffer len check
Takashi Iwai (6):
ALSA: usb-audio: Add implicit fb quirk for Behringer UFX1604
ALSA: usb-audio: Fix invalid NULL check in snd_emuusb_set_samplerate()
ALSA: line6: Fix memory leak at line6_init_pcm() error path
ALSA: usb-audio: Check mixer unit bitmap yet more strictly
ALSA: seq: Fix potential concurrent access to the deleted pool
sky2: Disable MSI on yet another ASUS boards (P6Xxxx)
Takashi Sakamoto (1):
ALSA: oxfw: fix to handle correct stream for PCM playback
Terry S. Duncan (1):
net/ncsi: Ensure 32-bit boundary for data cksum
Thomas Falcon (1):
ibmvnic: Do not process reset during or after device removal
Thomas Gleixner (3):
x86/apic: Fix arch_dynirq_lower_bound() bug for DT enabled machines
Documentation/process: Embargoed hardware security issues
x86/mm/cpa: Prevent large page split when ftrace flips RW on kernel text
Thomas Jarosch (1):
netfilter: nf_conntrack_ftp: Fix debug output
Todd Seidelmann (2):
netfilter: ebtables: Fix argument order to ADD_COUNTER
netfilter: xt_physdev: Fix spurious error message in physdev_mt_check
Tomas Winkler (1):
mei: me: add Tiger Lake point LP device ID
Tony Lindgren (7):
ARM: OMAP2+: Fix missing SYSC_HAS_RESET_STATUS for dra7 epwmss
bus: ti-sysc: Fix handling of forced idle
bus: ti-sysc: Fix using configured sysc mask value
ARM: dts: Fix flags for gpio7
ARM: dts: Fix incorrect dcan register mapping for am3, am4 and dra7
ARM: OMAP2+: Fix omap4 errata warning on other SoCs
ARM: dts: Fix incomplete dts data for am3 and am4 mmc
Trond Myklebust (17):
NFS: Don't refresh attributes with mounted-on-file information
NFSv4: Fix return values for nfs4_file_open()
NFSv4: Fix return value in nfs_finish_open()
NFSv4/pnfs: Fix a page lock leak in nfs_pageio_resend()
NFS: Ensure O_DIRECT reports an error if the bytes read/written is 0
NFS: Fix initialisation of I/O result struct in nfs_pgio_rpcsetup
NFS: On fatal writeback errors, we need to call nfs_inode_remove_request()
SUNRPC: Don't handle errors if the bind/connect succeeded
pNFS/flexfiles: Turn off soft RPC calls
SUNRPC: Handle EADDRINUSE and ENOBUFS correctly
Revert "NFSv4/flexfiles: Abort I/O early if the layout segment
was invalidated"
SUNRPC: Handle connection breakages correctly in call_status()
pNFS/flexfiles: Don't time out requests on hard mounts
NFS: Fix spurious EIO read errors
NFS: Fix writepage(s) error handling to not report errors twice
NFSv2: Fix eof handling
NFSv2: Fix write regression
Ulf Hansson (1):
mmc: core: Fix init of SD cards reporting an invalid VDD range
Ville Syrjälä (1):
drm/i915: Do not create a new max_bpc prop for MST connectors
Vitaly Kuznetsov (1):
KVM: x86: hyper-v: don't crash on KVM_GET_SUPPORTED_HV_CPUID
when kvm_intel.nested is disabled
Vlad Buslov (2):
nfp: flower: verify that block cb is not busy before binding
net: sched: act_sample: fix psample group handling on overwrite
Vladimir Oltean (4):
net: dsa: tag_8021q: Future-proof the reserved fields in the custom VID
taprio: Fix kernel panic in taprio_destroy
taprio: Set default link speed to 10 Mbps in taprio_set_picos_per_byte
net/sched: cbs: Set default link speed to 10 Mbps in cbs_set_port_rate
Wenwen Wang (1):
qed: Add cleanup in qed_slowpath_start()
Willem de Bruijn (1):
tcp: inherit timestamp on mtu probe
Wolfram Sang (1):
i2c: make i2c_unregister_device() ERR_PTR safe
Xavier Ruppen (1):
arm64: dts: amlogic: odroid-n2: keep SD card regulator always on
Xinpeng Liu (1):
tracing/probe: Fix null pointer dereference
Xiong Zhang (1):
drm/i915: Don't deballoon unused ggtt drm_mm_node in linux guest
Yangbo Lu (1):
ocelot_ace: fix action of trap
Yash Shah (2):
macb: bindings doc: update sifive fu540-c000 binding
macb: Update compatibility string for SiFive FU540-C000
Yazen Ghannam (1):
tools/power turbostat: Make interval calculation per thread to
reduce jitter
Yi-Hung Wei (2):
openvswitch: Fix log message in ovs conntrack
openvswitch: Fix conntrack cache with timeout
Yoshihiro Shimoda (1):
usb: host: ohci: fix a race condition between shutdown and irq
YueHaibing (5):
ieee802154: hwsim: Fix error handle path in hwsim_init_module
ieee802154: hwsim: unregister hw while hwsim_subscribe_all_others fails
soc: ti: pm33xx: Make two symbols static
NFS: remove set but not used variable 'mapping'
amd-xgbe: Fix error path in xgbe_mod_init()
Zephaniah E. Loss-Cutler-Hull (1):
tools/power x86_energy_perf_policy: Fix argument parsing
Zhang Rui (1):
tools/power turbostat: add Jacobsville support
Zhu Yanjun (1):
net: rds: add service level support in rds-info
james qian wang (Arm Technology China) (3):
drm/komeda: Fix error: not allocating enough data 1592 vs 1584
drm/komeda: Fix warning -Wunused-but-set-variable
drm/komeda: Clean warning 'komeda_component_add' might be a
candidate for 'gnu_printf'
wenxu (1):
netfilter: nft_meta_bridge: Fix get NFT_META_BRI_IIFVPROTO in
network byteorder
zhanglin (1):
sock: fix potential memory leak in proto_register()
zhaoyang (1):
ARM: 8901/1: add a criteria for pfn_valid of arm
Quoting Thomas Gleixner (2019-09-07 16:00:17)
> Does this only happen with that CPU0 hotplug stuff enabled or on CPUs other
> than CPU0 as well? That hotplug CPU0 stuff is a bandaid so I wouldn't be
> surprised if we broke that somehow.
If I ignore cpu0 in that test and so use
[ 133.847187] smpboot: CPU 1 is now offline
[ 134.861861] x86: Booting SMP configuration:
[ 134.861875] smpboot: Booting Node 0 Processor 1 APIC 0x2
[ 134.880218] smpboot: CPU 2 is now offline
[ 135.893806] smpboot: Booting Node 0 Processor 2 APIC 0x1
[ 135.935115] smpboot: CPU 3 is now offline
[ 136.949760] smpboot: Booting Node 0 Processor 3 APIC 0x3
that has run for 10 minutes without failure, so it seems confined to
cpu0 hotplugging. All we are doing in the test to generate the hotplugs
is:
for (int cpu = 0;; cpu++) {
char name[128];
int cpufd;
snprintf(name, sizeof(name),
"/sys/devices/system/cpu/cpu%d/online",
cpu), sizeof(name));
cpufd = open(name, O_WRONLY);
if (cpufd < 0)
break;
write(cpufd, "0", 2);
usleep(1e6);
write(cpufd, "1", 2);
close(cpufd);
}
-Chris
On Sat, Sep 7, 2019 at 8:00 AM Thomas Gleixner <[email protected]> wrote:
>
> Ok let me find a testbox to figure out whats wrong there.
Honestly, it looks like we should just revert that commit, since we
never used to clear the LDR bits before either, and the bug it "fixes"
doesn't really seem to be a bug (well, it's a bug in KVM, but that's a
different thing).
And I wouldn't be at all surprised if it confuses some BIOS code.
We use the LDR bits ourselves in smp_get_logical_apicid(), and so
clearing them out seems entirely bogus.
At a guess, it's wakeup_cpu_via_init_nmi() that does that
if (apic->dest_logical == APIC_DEST_LOGICAL)
id = cpu0_logical_apicid;
else
id = apicid;
and now that we've cleared the APIC LDR bits, we no longer wake the
BSP. We send the NMI to the _old_ APIC ID, but we've overwritten it
with 0 when we put it to sleep, so now nothing happens.
I'm really not clear on why it's a good idea to clear the LDR bits on
shutdown, and commit 558682b52919 ("x86/apic: Include the LDR when
clearing out APIC registers") just looks pointless. And now it has
proven to break some machines.
So why wouldn't we just revert it?
Linus
On Sat, Sep 7, 2019 at 1:44 PM Thomas Gleixner <[email protected]> wrote:
>
> That's what I just replied to Chris. Can you do it right away or should I queue it up?
Done.
Thanks,
Linus
On Sat, Sep 07, 2019 at 02:13:22PM -0700, Linus Torvalds wrote:
>On Sat, Sep 7, 2019 at 1:44 PM Thomas Gleixner <[email protected]> wrote:
>>
>> That's what I just replied to Chris. Can you do it right away or should I queue it up?
>
>Done.
I'd like to bring back a discussion we had last year on ksummit-discuss:
https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2018-May/005122.html
. I've pointed out that some of the commits that go in the -rc cycles
are of low quality and are untested, you seemed to agree but said that
it's "by-design" because late -rc cycle commits are more complex.
Is this commit and it's fallout really how our development process
should be working?
This commit was rushed through the process: it was authored and merged
into -tip of the same day, and pulled in by you just a few days later.
There was no meaningful time for review, testing, or really any sort of
QA.
We really do have a better story now for catching the sort of issues
introduced by these patch: multiple CI systems tripped on this, but
people still need the time to look into it, make sure that the failure
is real and bisect it.
What was the rush in making it skip all of our safeguards? The "bug" has
been there forever, the fix isn't urgent, and no one seemed to care for
quite a while.
Even if this patch was fixing a bug introduced in this merge window, is
the tradeoff around rushing an untested fix worth it vs giving it more
time and shipping it as part of our stable tree?
I'm not trying to pick on this patch in particular - I feel that this is
a systematic issue and should be addressed as part of our process.
--
Thanks,
Sasha
Quoting Linus Torvalds (2019-09-02 18:28:26)
> Bandan Das:
> x86/apic: Include the LDR when clearing out APIC registers
Apologies if this is known already, I'm way behind on email.
I've bisected
[ 18.693846] smpboot: CPU 0 is now offline
[ 19.707737] smpboot: Booting Node 0 Processor 0 APIC 0x0
[ 29.707602] smpboot: do_boot_cpu failed(-1) to wakeup CPU#0
https://intel-gfx-ci.01.org/tree/drm-tip/igt@[email protected]
to 558682b52919. (Reverts cleanly and fixes the problem.)
I'm guessing that this is also behind the suspend failures, missing
/dev/cpu/0/msr, and random perf_event_open() failures we have observed
in our CI since -rc7 across all generations of Intel cpus.
-Chris
On Sat, 7 Sep 2019, Chris Wilson wrote:
> Quoting Linus Torvalds (2019-09-02 18:28:26)
> > Bandan Das:
> > x86/apic: Include the LDR when clearing out APIC registers
>
> Apologies if this is known already, I'm way behind on email.
>
> I've bisected
>
> [ 18.693846] smpboot: CPU 0 is now offline
> [ 19.707737] smpboot: Booting Node 0 Processor 0 APIC 0x0
> [ 29.707602] smpboot: do_boot_cpu failed(-1) to wakeup CPU#0
>
> https://intel-gfx-ci.01.org/tree/drm-tip/igt@[email protected]
>
> to 558682b52919. (Reverts cleanly and fixes the problem.)
>
> I'm guessing that this is also behind the suspend failures, missing
> /dev/cpu/0/msr, and random perf_event_open() failures we have observed
> in our CI since -rc7 across all generations of Intel cpus.
So is this on bare metal or in a VM?
Thanks,
tglx
Quoting Thomas Gleixner (2019-09-07 15:29:19)
> On Sat, 7 Sep 2019, Chris Wilson wrote:
> > Quoting Linus Torvalds (2019-09-02 18:28:26)
> > > Bandan Das:
> > > x86/apic: Include the LDR when clearing out APIC registers
> >
> > Apologies if this is known already, I'm way behind on email.
> >
> > I've bisected
> >
> > [ 18.693846] smpboot: CPU 0 is now offline
> > [ 19.707737] smpboot: Booting Node 0 Processor 0 APIC 0x0
> > [ 29.707602] smpboot: do_boot_cpu failed(-1) to wakeup CPU#0
> >
> > https://intel-gfx-ci.01.org/tree/drm-tip/igt@[email protected]
> >
> > to 558682b52919. (Reverts cleanly and fixes the problem.)
> >
> > I'm guessing that this is also behind the suspend failures, missing
> > /dev/cpu/0/msr, and random perf_event_open() failures we have observed
> > in our CI since -rc7 across all generations of Intel cpus.
>
> So is this on bare metal or in a VM?
Our single virtualised piece of kit doesn't support cpu hotplug, so this
test is not being run. We have failures on
icl (2019), glk (2017), kbl (2017), bxt (2016), skl (2015),
bsw (2016), hsw (2013), byt (2013), snb (2011), elk (2008),
bwr (2006), blb (2007)
-Chris
On Sat, 7 Sep 2019, Chris Wilson wrote:
> Quoting Thomas Gleixner (2019-09-07 15:29:19)
> > On Sat, 7 Sep 2019, Chris Wilson wrote:
> > > Quoting Linus Torvalds (2019-09-02 18:28:26)
> > > > Bandan Das:
> > > > x86/apic: Include the LDR when clearing out APIC registers
> > >
> > > Apologies if this is known already, I'm way behind on email.
> > >
> > > I've bisected
> > >
> > > [ 18.693846] smpboot: CPU 0 is now offline
> > > [ 19.707737] smpboot: Booting Node 0 Processor 0 APIC 0x0
> > > [ 29.707602] smpboot: do_boot_cpu failed(-1) to wakeup CPU#0
> > >
> > > https://intel-gfx-ci.01.org/tree/drm-tip/igt@[email protected]
> > >
> > > to 558682b52919. (Reverts cleanly and fixes the problem.)
> > >
> > > I'm guessing that this is also behind the suspend failures, missing
> > > /dev/cpu/0/msr, and random perf_event_open() failures we have observed
> > > in our CI since -rc7 across all generations of Intel cpus.
> >
> > So is this on bare metal or in a VM?
>
> Our single virtualised piece of kit doesn't support cpu hotplug, so this
> test is not being run. We have failures on
> icl (2019), glk (2017), kbl (2017), bxt (2016), skl (2015),
> bsw (2016), hsw (2013), byt (2013), snb (2011), elk (2008),
> bwr (2006), blb (2007)
Ok let me find a testbox to figure out whats wrong there.
Does this only happen with that CPU0 hotplug stuff enabled or on CPUs other
than CPU0 as well? That hotplug CPU0 stuff is a bandaid so I wouldn't be
surprised if we broke that somehow.
Thanks,
tglx
On Sat, Sep 7, 2019 at 12:17 PM Linus Torvalds
<[email protected]> wrote:
>
> I'm really not clear on why it's a good idea to clear the LDR bits on
> shutdown, and commit 558682b52919 ("x86/apic: Include the LDR when
> clearing out APIC registers") just looks pointless. And now it has
> proven to break some machines.
>
> So why wouldn't we just revert it?
Side note: looking around for the discussion about this patch, at
least one version of the patch from Bandan had
+ if (!x2apic_enabled) {
rather than
+ if (!x2apic_enabled()) {
which meant that whatever Bandan tested at that point was actually a
complete no-op, since "!x2apic_enabled" is never true (it tests a
function pointer against NULL, which it won't be).
Then that was fixed by the time it hit -tip (and eventually my tree),
but it kind of shows how the patch history of this is all
questionable. Further strengthened by a quote from that discussion:
"this is really a KVM bug but it doesn't hurt to clear out the LDR in
the guest and then, it wouldn't need a hypervisor fix"
and clearly it *does* hurt to clear the LDR in the guest, making the
whole thinking behind the patch wrong and broken. The kernel clearly
_does_ depend on LDR having the right contents.
Now, I still suspect the boot problem then comes from our
cpu0_logical_apicid use mentioned in that previous email, but at this
point I think the proper fix is "revert for now, and we can look at
this as a cleanup with the cpu0_logical_apicid thing for 5.4 instead".
Hmm?
Linus
On Sat, 7 Sep 2019, Chris Wilson wrote:
> Quoting Thomas Gleixner (2019-09-07 16:00:17)
> > Does this only happen with that CPU0 hotplug stuff enabled or on CPUs other
> > than CPU0 as well? That hotplug CPU0 stuff is a bandaid so I wouldn't be
> > surprised if we broke that somehow.
>
> If I ignore cpu0 in that test and so use
>
> [ 133.847187] smpboot: CPU 1 is now offline
> [ 134.861861] x86: Booting SMP configuration:
> [ 134.861875] smpboot: Booting Node 0 Processor 1 APIC 0x2
> [ 134.880218] smpboot: CPU 2 is now offline
> [ 135.893806] smpboot: Booting Node 0 Processor 2 APIC 0x1
> [ 135.935115] smpboot: CPU 3 is now offline
> [ 136.949760] smpboot: Booting Node 0 Processor 3 APIC 0x3
>
> that has run for 10 minutes without failure, so it seems confined to
> cpu0 hotplugging. All we are doing in the test to generate the hotplugs
> is:
Right, but you also have that config bit enabled which allows CPU0 hotplug
which usually is off even in testing and that's why nobody noticed so far.
So I looked at that code and I know why it's broken. I guess we'll end up
reverting that commit for now as fixing it proper will be not just a one
liner.
Thanks for providing all the information!
tglx
On Sat, 7 Sep 2019, Linus Torvalds wrote:
> On Sat, Sep 7, 2019 at 8:00 AM Thomas Gleixner <[email protected]> wrote:
>
> So why wouldn't we just revert it?
That's what I just replied to Chris. Can you do it right away or should I queue it up?
Thanks,
tglx
Linus Torvalds <[email protected]> writes:
> On Sat, Sep 7, 2019 at 12:17 PM Linus Torvalds
> <[email protected]> wrote:
>>
>> I'm really not clear on why it's a good idea to clear the LDR bits on
>> shutdown, and commit 558682b52919 ("x86/apic: Include the LDR when
>> clearing out APIC registers") just looks pointless. And now it has
>> proven to break some machines.
>>
>> So why wouldn't we just revert it?
>
> Side note: looking around for the discussion about this patch, at
> least one version of the patch from Bandan had
>
> + if (!x2apic_enabled) {
>
> rather than
>
> + if (!x2apic_enabled()) {
>
I believe this crept up by accident when I was preparing the series, my testing
was with x2apic_enabled() but I didn't test CPU hotplug - only the kdump path
with 32 bit guest. In hindsight, I should have been more careful with testing,
sorry about that.
Bandan
> which meant that whatever Bandan tested at that point was actually a
> complete no-op, since "!x2apic_enabled" is never true (it tests a
> function pointer against NULL, which it won't be).
>
> Then that was fixed by the time it hit -tip (and eventually my tree),
> but it kind of shows how the patch history of this is all
> questionable. Further strengthened by a quote from that discussion:
>
> "this is really a KVM bug but it doesn't hurt to clear out the LDR in
> the guest and then, it wouldn't need a hypervisor fix"
>
> and clearly it *does* hurt to clear the LDR in the guest, making the
> whole thinking behind the patch wrong and broken. The kernel clearly
> _does_ depend on LDR having the right contents.
>
> Now, I still suspect the boot problem then comes from our
> cpu0_logical_apicid use mentioned in that previous email, but at this
> point I think the proper fix is "revert for now, and we can look at
> this as a cleanup with the cpu0_logical_apicid thing for 5.4 instead".
>
> Hmm?
>
> Linus