2020-10-28 19:31:28

by Geert Uytterhoeven

Subject: [PATCH] mm/process_vm_access: Add missing #include <linux/compat.h>

With e.g. m68k/defconfig:

mm/process_vm_access.c: In function ‘process_vm_rw’:
mm/process_vm_access.c:277:5: error: implicit declaration of function ‘in_compat_syscall’ [-Werror=implicit-function-declaration]
277 | in_compat_syscall());
| ^~~~~~~~~~~~~~~~~

Fix this by adding #include <linux/compat.h>.

Reported-by: [email protected]
Fixes: 38dc5079da7081e8 ("Fix compat regression in process_vm_rw()")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
mm/process_vm_access.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c
index 05676722d9cd6afb..702250f148e73adc 100644
--- a/mm/process_vm_access.c
+++ b/mm/process_vm_access.c
@@ -5,6 +5,7 @@
* Copyright (C) 2010-2011 Christopher Yeoh <[email protected]>, IBM Corp.
*/

+#include <linux/compat.h>
#include <linux/mm.h>
#include <linux/uio.h>
#include <linux/sched.h>
--
2.25.1

2020-10-28 20:54:34

by Jens Axboe

Subject: Re: [PATCH] mm/process_vm_access: Add missing #include <linux/compat.h>

On 10/27/20 12:22 PM, Geert Uytterhoeven wrote:
> With e.g. m68k/defconfig:
>
> mm/process_vm_access.c: In function ‘process_vm_rw’:
> mm/process_vm_access.c:277:5: error: implicit declaration of function ‘in_compat_syscall’ [-Werror=implicit-function-declaration]
> 277 | in_compat_syscall());
> | ^~~~~~~~~~~~~~~~~
>
> Fix this by adding #include <linux/compat.h>.

Oversight on my part, didn't fail on my configs. Linus, can you pick
this one up?

Acked-by: Jens Axboe <[email protected]>

--
Jens Axboe

2020-10-28 21:01:20

by Linus Torvalds

Subject: Re: [PATCH] mm/process_vm_access: Add missing #include <linux/compat.h>

On Tue, Oct 27, 2020 at 12:33 PM Jens Axboe <[email protected]> wrote:
>
> Oversight on my part, didn't fail on my configs. Linus, can you pick
> this one up?

Done.

Linus