2022-07-08 07:53:25

by Peter Zijlstra

[permalink] [raw]
Subject: [PATCH 0/4] munmap() vs unmap_mapping_range()

Hi,

These 4 patches implement the suggestion by Linus.

The first patch nukes all architecture implementations of tlb_{start,end}_vma()
by adding two additional MMU_GATHER config knobs.

DaveM, please clarify the sparc64 case, it seems a little odd to have
flush_cache_range() but to explicitly not call it at unmap time. It would be
nice to remove this one special case.

The second patch isn't strictly needed for this series but since I was looking
at all this, I figured C-SKY didn't make a whole lot of sense. Guo, please
have a look.

The third patch cleans up the #ifdeffery and provides a single
tlb_{start,end}_vma() implementation for everyone.

The fourth, and final, patch does the force TLB-flush on VM_PFNMAP thing.

I've had the first three patches exposed to the robots and they've (so far) not
reported build (or other) fail.


2022-07-21 08:46:39

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [PATCH 0/4] munmap() vs unmap_mapping_range()

On Fri, Jul 08, 2022 at 09:18:02AM +0200, Peter Zijlstra wrote:
> Hi,
>
> These 4 patches implement the suggestion by Linus.
>
> The first patch nukes all architecture implementations of tlb_{start,end}_vma()
> by adding two additional MMU_GATHER config knobs.
>
> DaveM, please clarify the sparc64 case, it seems a little odd to have
> flush_cache_range() but to explicitly not call it at unmap time. It would be
> nice to remove this one special case.
>
> The second patch isn't strictly needed for this series but since I was looking
> at all this, I figured C-SKY didn't make a whole lot of sense. Guo, please
> have a look.
>
> The third patch cleans up the #ifdeffery and provides a single
> tlb_{start,end}_vma() implementation for everyone.
>
> The fourth, and final, patch does the force TLB-flush on VM_PFNMAP thing.
>
> I've had the first three patches exposed to the robots and they've (so far) not
> reported build (or other) fail.
>

What are we doing with these patches? Andrew will you pick them up, or
will I smuggle them in x86/mm or something ?

2022-07-21 18:03:12

by Linus Torvalds

[permalink] [raw]
Subject: Re: [PATCH 0/4] munmap() vs unmap_mapping_range()

On Thu, Jul 21, 2022 at 1:37 AM Peter Zijlstra <[email protected]> wrote:
>
> What are we doing with these patches? Andrew will you pick them up, or
> will I smuggle them in x86/mm or something ?

I'm picking up other random things right now anyway as people have
emailed me, so I'll just do that with this series too.

Linus

2022-07-21 18:13:09

by Linus Torvalds

[permalink] [raw]
Subject: Re: [PATCH 0/4] munmap() vs unmap_mapping_range()

On Thu, Jul 21, 2022 at 10:46 AM Linus Torvalds
<[email protected]> wrote:
>
> I'm picking up other random things right now anyway as people have
> emailed me, so I'll just do that with this series too.

.. and I took the suggestion from Jann to make that last patch also
check VM_MIXEDMAP in addition to VM_PFNMAP.

Linus