Hi all,
After merging the origin tree, today's linux-next build (sparc defconfig)
failed like this:
<stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/home/sfr/next/next/arch/sparc/mm/fault_32.c: In function 'force_user_fault':
/home/sfr/next/next/arch/sparc/mm/fault_32.c:315:49: error: 'regs' undeclared (first use in this function)
315 | vma = lock_mm_and_find_vma(mm, address, regs);
| ^~~~
Caused by commit
a050ba1e7422 ("mm/fault: convert remaining simple cases to lock_mm_and_find_vma()")
I have just left this broken for today.
--
Cheers,
Stephen Rothwell
On Thu, 29 Jun 2023 at 19:59, Stephen Rothwell <[email protected]> wrote:
>
> After merging the origin tree, today's linux-next build (sparc defconfig)
> failed like this:
>
> /home/sfr/next/next/arch/sparc/mm/fault_32.c: In function 'force_user_fault':
> /home/sfr/next/next/arch/sparc/mm/fault_32.c:315:49: error: 'regs' undeclared (first use in this function)
> 315 | vma = lock_mm_and_find_vma(mm, address, regs);
Duh. Yeah, the register window faults don't pass the user register
state pointer around, and as noted in commit a050ba1e7422 those
left-over conversions were mostly done blind.
The fix is trivial - just pass in NULL for the regs pointer. It's not required.
Said fix pushed out. Thanks,
Linus