2013-08-20 10:03:13

by Prasad Pandit

Subject: About perf,arm -- oops in validate_event

Hello,

-> https://lkml.org/lkml/2013/8/7/259

I wanted to confirm if this above fix should also go into ARM64 build Or is
ARM64 platform not vulnerable?

===
$ git diff
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index 9ba33c4..cbed82f 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -317,6 +317,9 @@ validate_event(struct pmu_hw_events *hw_events,
struct hw_perf_event fake_event = event->hw;
struct pmu *leader_pmu = event->group_leader->pmu;

+ if (is_software_event(event))
+ return 1;
+
if (event->pmu != leader_pmu || event->state <= PERF_EVENT_STATE_OFF)
return 1;
===


Thank you.
--
Prasad J Pandit / Red Hat Security Response Team
DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602B

2013-08-20 10:39:30

by Catalin Marinas

Subject: Re: About perf,arm -- oops in validate_event

On 20 August 2013 11:03, P J P <[email protected]> wrote:
> -> https://lkml.org/lkml/2013/8/7/259
>
> I wanted to confirm if this above fix should also go into ARM64 build Or is
> ARM64 platform not vulnerable?

It is and I'll push patches to mainline (Will is preparing them).

Catalin

2013-08-20 14:44:07

by Vince Weaver

Subject: Re: About perf,arm -- oops in validate_event

On Tue, 20 Aug 2013, Catalin Marinas wrote:

> On 20 August 2013 11:03, P J P <[email protected]> wrote:
> > -> https://lkml.org/lkml/2013/8/7/259
> >
> > I wanted to confirm if this above fix should also go into ARM64 build Or is
> > ARM64 platform not vulnerable?
>
> It is and I'll push patches to mainline (Will is preparing them).

You'll probably also want the equivalent of
d9f966357b14e356dbd83b8f4a197a287ab4ff83
as well since arch/arm64/kernel/perf_event.c
has the same overflow in armpmu_map_event that is fixed in the mentioned
commit.

Vince

2013-08-20 16:16:33

by Catalin Marinas

Subject: Re: About perf,arm -- oops in validate_event

On Tue, Aug 20, 2013 at 03:42:56PM +0100, Vince Weaver wrote:
> On Tue, 20 Aug 2013, Catalin Marinas wrote:
>
> > On 20 August 2013 11:03, P J P <[email protected]> wrote:
> > > -> https://lkml.org/lkml/2013/8/7/259
> > >
> > > I wanted to confirm if this above fix should also go into ARM64 build Or is
> > > ARM64 platform not vulnerable?
> >
> > It is and I'll push patches to mainline (Will is preparing them).
>
> You'll probably also want the equivalent of
> d9f966357b14e356dbd83b8f4a197a287ab4ff83
> as well since arch/arm64/kernel/perf_event.c
> has the same overflow in armpmu_map_event that is fixed in the mentioned
> commit.

Yes, I'm pushing both.

Thanks.

--
Catalin