2022-10-24 18:33:12

by Jason A. Donenfeld

Subject: [PATCH] media: stv0288: use explicitly signed char

With char becoming unsigned by default, and with `char` alone being
ambiguous and based on architecture, signed chars need to be marked
explicitly as such. Use `s8` and `u8` types here, since that's what
surrounding code does. This fixes:

drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: assigning (-9) to unsigned variable 'tm'
drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: we never enter this loop

Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
Signed-off-by: Jason A. Donenfeld <[email protected]>
---
drivers/media/dvb-frontends/stv0288.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/dvb-frontends/stv0288.c b/drivers/media/dvb-frontends/stv0288.c
index 3d54a0ec86af..3ae1f3a2f142 100644
--- a/drivers/media/dvb-frontends/stv0288.c
+++ b/drivers/media/dvb-frontends/stv0288.c
@@ -440,9 +440,8 @@ static int stv0288_set_frontend(struct dvb_frontend *fe)
struct stv0288_state *state = fe->demodulator_priv;
struct dtv_frontend_properties *c = &fe->dtv_property_cache;

- char tm;
- unsigned char tda[3];
- u8 reg, time_out = 0;
+ u8 tda[3], reg, time_out = 0;
+ s8 tm;

dprintk("%s : FE_SET_FRONTEND\n", __func__);

--
2.38.1

2022-11-02 03:37:41

by Jason A. Donenfeld

Subject: Re: [PATCH] media: stv0288: use explicitly signed char

Hi Mauro,

On Mon, Oct 24, 2022 at 6:28 PM Jason A. Donenfeld <[email protected]> wrote:
>
> With char becoming unsigned by default, and with `char` alone being
> ambiguous and based on architecture, signed chars need to be marked
> explicitly as such. Use `s8` and `u8` types here, since that's what
> surrounding code does. This fixes:
>
> drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: assigning (-9) to unsigned variable 'tm'
> drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: we never enter this loop
>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]
> Signed-off-by: Jason A. Donenfeld <[email protected]>

Was wondering whether you planned on taking this into your tree as a
6.1 fix for Linus for rc4?

Thanks,
Jason

2022-11-11 03:08:26

by Jason A. Donenfeld

Subject: Re: [PATCH] media: stv0288: use explicitly signed char

Hi Mauro,

On Wed, Nov 2, 2022 at 3:47 AM Jason A. Donenfeld <[email protected]> wrote:
>
> Hi Mauro,
>
> On Mon, Oct 24, 2022 at 6:28 PM Jason A. Donenfeld <[email protected]> wrote:
> >
> > With char becoming unsigned by default, and with `char` alone being
> > ambiguous and based on architecture, signed chars need to be marked
> > explicitly as such. Use `s8` and `u8` types here, since that's what
> > surrounding code does. This fixes:
> >
> > drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: assigning (-9) to unsigned variable 'tm'
> > drivers/media/dvb-frontends/stv0288.c:471 stv0288_set_frontend() warn: we never enter this loop
> >
> > Cc: Mauro Carvalho Chehab <[email protected]>
> > Cc: [email protected]
> > Signed-off-by: Jason A. Donenfeld <[email protected]>
>
> Was wondering whether you planned on taking this into your tree as a
> 6.1 fix for Linus for rc4?

Thought I should follow up with you about this again.

Thanks,
Jason