2022-06-06 05:02:41

by Xiang wangx

Subject: [PATCH] serial: 8250: 8250_omap: Fix syntax errors in comments

Delete the redundant word 'have'.

Signed-off-by: Xiang wangx <[email protected]>
---
drivers/tty/serial/8250/8250_omap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
index ac8bfa042391..a7a95c013fe6 100644
--- a/drivers/tty/serial/8250/8250_omap.c
+++ b/drivers/tty/serial/8250/8250_omap.c
@@ -345,7 +345,7 @@ static void omap8250_restore_regs(struct uart_8250_port *up)
}

/*
- * OMAP can use "CLK / (16 or 13) / div" for baud rate. And then we have have
+ * OMAP can use "CLK / (16 or 13) / div" for baud rate. And then we have
* some differences in how we want to handle flow control.
*/
static void omap_8250_set_termios(struct uart_port *port,
--
2.36.1

2022-06-06 14:45:29

by Andy Shevchenko

Subject: Re: [PATCH] serial: 8250: 8250_omap: Fix syntax errors in comments

On Mon, Jun 6, 2022 at 5:25 AM Xiang wangx <[email protected]> wrote:
>
> Delete the redundant word 'have'.

Not critical right now, but you may shorten the subject by dropping
"8250:" part in the prefix, just leaving "serial: 8250_omap:" is
enough.

Reviewed-by: Andy Shevchenko <[email protected]>

> Signed-off-by: Xiang wangx <[email protected]>
> ---
> drivers/tty/serial/8250/8250_omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
> index ac8bfa042391..a7a95c013fe6 100644
> --- a/drivers/tty/serial/8250/8250_omap.c
> +++ b/drivers/tty/serial/8250/8250_omap.c
> @@ -345,7 +345,7 @@ static void omap8250_restore_regs(struct uart_8250_port *up)
> }
>
> /*
> - * OMAP can use "CLK / (16 or 13) / div" for baud rate. And then we have have
> + * OMAP can use "CLK / (16 or 13) / div" for baud rate. And then we have
> * some differences in how we want to handle flow control.
> */
> static void omap_8250_set_termios(struct uart_port *port,
> --
> 2.36.1
>


--
With Best Regards,
Andy Shevchenko