2021-02-08 09:19:51

by Luo Jiaxing

Subject: [PATCH for next v1 2/2] gpio: grgpio: Replace spin_lock_irqsave with spin_lock in grgpio_irq_handler()

There is no need to use API with _irqsave in grgpio_irq_handler(),
because it already be in a irq-disabled context.

Signed-off-by: Luo Jiaxing <[email protected]>
---
drivers/gpio/gpio-grgpio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
index f954359..fa5aa31 100644
--- a/drivers/gpio/gpio-grgpio.c
+++ b/drivers/gpio/gpio-grgpio.c
@@ -195,11 +195,10 @@ static irqreturn_t grgpio_irq_handler(int irq, void *dev)
{
struct grgpio_priv *priv = dev;
int ngpio = priv->gc.ngpio;
- unsigned long flags;
int i;
int match = 0;

- spin_lock_irqsave(&priv->gc.bgpio_lock, flags);
+ spin_lock(&priv->gc.bgpio_lock);

/*
* For each gpio line, call its interrupt handler if it its underlying
@@ -215,7 +214,7 @@ static irqreturn_t grgpio_irq_handler(int irq, void *dev)
}
}

- spin_unlock_irqrestore(&priv->gc.bgpio_lock, flags);
+ spin_unlock(&priv->gc.bgpio_lock);

if (!match)
dev_warn(priv->dev, "No gpio line matched irq %d\n", irq);
--
2.7.4

2021-02-10 10:57:11

by Andy Shevchenko

Subject: Re: [PATCH for next v1 2/2] gpio: grgpio: Replace spin_lock_irqsave with spin_lock in grgpio_irq_handler()

On Mon, Feb 8, 2021 at 10:58 AM Luo Jiaxing <[email protected]> wrote:
>
> There is no need to use API with _irqsave in grgpio_irq_handler(),
> because it already be in a irq-disabled context.

It seems you haven't read the code. The handler here is shared. And
lock there is about something else that we discussed in the cover
letter.
Moreover, the driver is quite outdated and code inside is horrible
according to the modern APIs / standards.

I would rather remove the driver completely.

--
With Best Regards,
Andy Shevchenko