2020-01-12 12:21:11

by Vadim Pasternak

Subject: [PATCH platform-next v2 03/10] Documentation/ABI: Add missed attribute for mlxreg-io sysfs interfaces

Add missed "cpld4_version" attribute.

Signed-off-by: Vadim Pasternak <[email protected]>
---
Documentation/ABI/stable/sysfs-driver-mlxreg-io | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/Documentation/ABI/stable/sysfs-driver-mlxreg-io b/Documentation/ABI/stable/sysfs-driver-mlxreg-io
index 8b1461fa3538..fe30fe505c9b 100644
--- a/Documentation/ABI/stable/sysfs-driver-mlxreg-io
+++ b/Documentation/ABI/stable/sysfs-driver-mlxreg-io
@@ -121,6 +121,16 @@ Description: These files show the system reset cause, as following: ComEx

The files are read only.

+What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/cpld4_version
+
+Date: November 2018
+KernelVersion: 5.0
+Contact: Vadim Pasternak <vadimpmellanox.com>
+Description: These files show with which CPLD versions have been burned
+ on LED board.
+
+ The files are read only.
+
Date: June 2019
KernelVersion: 5.3
Contact: Vadim Pasternak <vadimpmellanox.com>
--
2.11.0

2020-01-13 14:14:27

by Andy Shevchenko

Subject: Re: [PATCH platform-next v2 03/10] Documentation/ABI: Add missed attribute for mlxreg-io sysfs interfaces

On Sun, Jan 12, 2020 at 2:19 PM Vadim Pasternak <[email protected]> wrote:
>
> Add missed "cpld4_version" attribute.
>

Fixes tag?
Also see below.

...

> +What: /sys/devices/platform/mlxplat/mlxreg-io/hwmon/hwmon*/cpld4_version

> +

Can we get some consistency here, i.e. drop blank lines between What
and Date everywhere?
(Separate patch)

> +Date: November 2018
> +KernelVersion: 5.0
> +Contact: Vadim Pasternak <vadimpmellanox.com>
> +Description: These files show with which CPLD versions have been burned
> + on LED board.
> +
> + The files are read only.
> +

...following by the starting each section with What keyword.

(Separate patch)

> Date: June 2019
> KernelVersion: 5.3
> Contact: Vadim Pasternak <vadimpmellanox.com>


--
With Best Regards,
Andy Shevchenko