2019-06-02 16:37:10

by Emanuel Bennici

Subject: [PATCH v2] pci: hotplug: ibmphp: Remove superfluous debug message

The 'Exit' Debug message is superfluous ftrace can be used instead.

Signed-off-by: Emanuel Bennici <[email protected]>
---
drivers/pci/hotplug/ibmphp_core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
index cd73bea12bc7..a2ea1ff6cfbc 100644
--- a/drivers/pci/hotplug/ibmphp_core.c
+++ b/drivers/pci/hotplug/ibmphp_core.c
@@ -890,7 +890,6 @@ static int set_bus(struct slot *slot_cur)
/* This is for x440, once Brandon fixes the firmware,
will not need this delay */
msleep(1000);
- debug("%s - Exit\n", __func__);
return 0;
}

--
2.19.1

2019-06-05 08:45:33

by Andy Shevchenko

Subject: Re: [PATCH v2] pci: hotplug: ibmphp: Remove superfluous debug message

On Sun, Jun 2, 2019 at 7:35 PM Emanuel Bennici
<[email protected]> wrote:
>
> The 'Exit' Debug message is superfluous ftrace can be used instead.
>

When reviewer gives you a comment in one entry, your job is to check
your entire series and address the same comment in other places.
There are many such unneeded debug messages.

--
With Best Regards,
Andy Shevchenko