2022-09-01 10:48:34

by Andy Shevchenko

Subject: Re: [PATCH] ACPI: platform: Use PLATFORM_DEVID_NONE in acpi_create_platform_device()

On Thu, Sep 1, 2022 at 1:10 PM John Garry <[email protected]> wrote:
>
> Instead of hardcoding the value for the id, use PLATFORM_DEVID_NONE.

Reviewed-by: Andy Shevchenko <[email protected]>

> Signed-off-by: John Garry <[email protected]>
>
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index de3cbf152dee..d33334c9b8e5 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -140,7 +140,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,
> pdevinfo.parent = adev->parent ?
> acpi_get_first_physical_node(adev->parent) : NULL;
> pdevinfo.name = dev_name(&adev->dev);
> - pdevinfo.id = -1;
> + pdevinfo.id = PLATFORM_DEVID_NONE;
> pdevinfo.res = resources;
> pdevinfo.num_res = count;
> pdevinfo.fwnode = acpi_fwnode_handle(adev);
> --
> 2.35.3
>


--
With Best Regards,
Andy Shevchenko

2022-09-03 19:09:30

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPI: platform: Use PLATFORM_DEVID_NONE in acpi_create_platform_device()

On Thu, Sep 1, 2022 at 12:25 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Thu, Sep 1, 2022 at 1:10 PM John Garry <[email protected]> wrote:
> >
> > Instead of hardcoding the value for the id, use PLATFORM_DEVID_NONE.
>
> Reviewed-by: Andy Shevchenko <[email protected]>
>
> > Signed-off-by: John Garry <[email protected]>
> >
> > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> > index de3cbf152dee..d33334c9b8e5 100644
> > --- a/drivers/acpi/acpi_platform.c
> > +++ b/drivers/acpi/acpi_platform.c
> > @@ -140,7 +140,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,
> > pdevinfo.parent = adev->parent ?
> > acpi_get_first_physical_node(adev->parent) : NULL;
> > pdevinfo.name = dev_name(&adev->dev);
> > - pdevinfo.id = -1;
> > + pdevinfo.id = PLATFORM_DEVID_NONE;
> > pdevinfo.res = resources;
> > pdevinfo.num_res = count;
> > pdevinfo.fwnode = acpi_fwnode_handle(adev);
> > --

Applied as 6.1 material, thanks!