2021-10-01 15:52:43

by Andy Shevchenko

Subject: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h

There is no user of anything in uuid.h in the hyperv.h. Replace it with
more appropriate types.h.

Fixes: f081bbb3fd03 ("hyper-v: Remove internal types from UAPI header")
Reported-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
---
include/uapi/linux/hyperv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
index 6135d92e0d47..daf82a230c0e 100644
--- a/include/uapi/linux/hyperv.h
+++ b/include/uapi/linux/hyperv.h
@@ -26,7 +26,7 @@
#ifndef _UAPI_HYPERV_H
#define _UAPI_HYPERV_H

-#include <linux/uuid.h>
+#include <linux/types.h>

/*
* Framework version for util services.
--
2.33.0

2021-10-01 22:37:19

by Haiyang Zhang

Subject: RE: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h

> -----Original Message-----
> From: Andy Shevchenko <[email protected]>
> Sent: Friday, October 1, 2021 9:56 AM
> To: Andy Shevchenko <[email protected]>; linux-
> [email protected]; [email protected]
> Cc: KY Srinivasan <[email protected]>; Haiyang Zhang
> <[email protected]>; Stephen Hemminger <[email protected]>;
> Wei Liu <[email protected]>; Dexuan Cui <[email protected]>; Greg
> Kroah-Hartman <[email protected]>
> Subject: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h
>
> There is no user of anything in uuid.h in the hyperv.h. Replace it with
> more appropriate types.h.
>
> Fixes: f081bbb3fd03 ("hyper-v: Remove internal types from UAPI header")
> Reported-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> include/uapi/linux/hyperv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/hyperv.h b/include/uapi/linux/hyperv.h
> index 6135d92e0d47..daf82a230c0e 100644
> --- a/include/uapi/linux/hyperv.h
> +++ b/include/uapi/linux/hyperv.h
> @@ -26,7 +26,7 @@
> #ifndef _UAPI_HYPERV_H
> #define _UAPI_HYPERV_H
>
> -#include <linux/uuid.h>
> +#include <linux/types.h>
>
> /*

Hyper-v drivers are using uuid/guid APIs, but they can get the defs from
linux/mod_devicetable.h:

./include/linux/mod_devicetable.h:#include <linux/uuid.h>
./include/linux/hyperv.h:#include <uapi/linux/hyperv.h>
./include/linux/hyperv.h:#include <linux/mod_devicetable.h>

So your patch looks fine. Thanks.

Reviewed-by: Haiyang Zhang <[email protected]>

2021-10-02 07:53:02

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h

On Sat, Oct 2, 2021 at 1:36 AM Haiyang Zhang <[email protected]> wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <[email protected]>
> > Sent: Friday, October 1, 2021 9:56 AM

...

> Hyper-v drivers are using uuid/guid APIs, but they can get the defs from
> linux/mod_devicetable.h:
>
> ./include/linux/mod_devicetable.h:#include <linux/uuid.h>
> ./include/linux/hyperv.h:#include <uapi/linux/hyperv.h>
> ./include/linux/hyperv.h:#include <linux/mod_devicetable.h>

Yes, drivers inside the kernel may use that and this is the correct
way. The uAPI is not using it.

> So your patch looks fine. Thanks.
>
> Reviewed-by: Haiyang Zhang <[email protected]>

Thank you!


--
With Best Regards,
Andy Shevchenko

2021-10-06 12:10:54

by Wei Liu

Subject: Re: [PATCH v1 1/1] hyper-v: Replace uuid.h with types.h

On Sat, Oct 02, 2021 at 10:46:16AM +0300, Andy Shevchenko wrote:
> On Sat, Oct 2, 2021 at 1:36 AM Haiyang Zhang <[email protected]> wrote:
> > > -----Original Message-----
> > > From: Andy Shevchenko <[email protected]>
> > > Sent: Friday, October 1, 2021 9:56 AM
>
> ...
>
> > Hyper-v drivers are using uuid/guid APIs, but they can get the defs from
> > linux/mod_devicetable.h:
> >
> > ./include/linux/mod_devicetable.h:#include <linux/uuid.h>
> > ./include/linux/hyperv.h:#include <uapi/linux/hyperv.h>
> > ./include/linux/hyperv.h:#include <linux/mod_devicetable.h>
>
> Yes, drivers inside the kernel may use that and this is the correct
> way. The uAPI is not using it.
>
> > So your patch looks fine. Thanks.
> >
> > Reviewed-by: Haiyang Zhang <[email protected]>
>
> Thank you!

Applied to hyperv-fixes. Thanks.

Wei.

>
>
> --
> With Best Regards,
> Andy Shevchenko