The max98927 codec on some devices (i.e. Xiaomi Mi A2 Lite phone) requires
hardware-resetting the codec by driving a reset-gpio. This series adds
support for it through an optional reset-gpios property.
v4:
* Correctly assert/deassert the GPIO states
* Wait for the i2c port to be ready after reset
* Reset device when removed
v3:
* Fix indentation on the dev_err_probe line
v2:
* Use dev_err_probe instead of dev_err
Alejandro Tafalla (2):
ASoC: max98927: Handle reset gpio when probing i2c
dt-bindings: sound: max98927: Add reset-gpios optional property
.../devicetree/bindings/sound/max9892x.txt | 3 +++
sound/soc/codecs/max98927.c | 25 +++++++++++++++++++
sound/soc/codecs/max98927.h | 1 +
3 files changed, 29 insertions(+)
--
2.33.0
Signed-off-by: Alejandro Tafalla <[email protected]>
---
Documentation/devicetree/bindings/sound/max9892x.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/max9892x.txt b/Documentation/devicetree/bindings/sound/max9892x.txt
index f6171591ddc6..98cb9ba5b328 100644
--- a/Documentation/devicetree/bindings/sound/max9892x.txt
+++ b/Documentation/devicetree/bindings/sound/max9892x.txt
@@ -30,6 +30,9 @@ Required properties:
- reg : the I2C address of the device for I2C
+Optional properties:
+ - reset-gpios : GPIO to reset the device
+
Example:
codec: max98927@3a {
--
2.33.0
On 7/10/21 4:38 Alejandro Tafalla wrote:
> Signed-off-by: Alejandro Tafalla <[email protected]>
> ---
> Documentation/devicetree/bindings/sound/max9892x.txt | 3 +++
> 1 file changed, 3 insertions(+)
Sorry, I forgot to add: Acked-by: Rob Herring <[email protected]>
--
Alejandro Tafalla
On Thu, Oct 7, 2021 at 5:45 AM Alejandro Tafalla <[email protected]> wrote:
> On 7/10/21 4:38 Alejandro Tafalla wrote:
> > Signed-off-by: Alejandro Tafalla <[email protected]>
> > ---
> > Documentation/devicetree/bindings/sound/max9892x.txt | 3 +++
> > 1 file changed, 3 insertions(+)
>
> Sorry, I forgot to add: Acked-by: Rob Herring <[email protected]>
And commit messages?
--
With Best Regards,
Andy Shevchenko
On 7/10/21 9:06 Andy Shevchenko wrote:
> On Thu, Oct 7, 2021 at 5:45 AM Alejandro Tafalla <[email protected]> wrote:
> > On 7/10/21 4:38 Alejandro Tafalla wrote:
> > > Signed-off-by: Alejandro Tafalla <[email protected]>
> > > ---
> > >
> > > Documentation/devicetree/bindings/sound/max9892x.txt | 3 +++
> > > 1 file changed, 3 insertions(+)
> >
> > Sorry, I forgot to add: Acked-by: Rob Herring <[email protected]>
>
> And commit messages?
Right, can I resend this patch with the commit message or I have to resend the
other one too?
--
Alejandro Tafalla
On Thu, Oct 07, 2021 at 04:38:58AM +0200, Alejandro Tafalla wrote:
> Signed-off-by: Alejandro Tafalla <[email protected]>
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
On Thu, 7 Oct 2021 04:38:54 +0200, Alejandro Tafalla wrote:
> The max98927 codec on some devices (i.e. Xiaomi Mi A2 Lite phone) requires
> hardware-resetting the codec by driving a reset-gpio. This series adds
> support for it through an optional reset-gpios property.
>
> v4:
> * Correctly assert/deassert the GPIO states
> * Wait for the i2c port to be ready after reset
> * Reset device when removed
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: max98927: Handle reset gpio when probing i2c
commit: 4d67dc1998f1890a9d22d03208037075ea9f2562
[2/2] dt-bindings: sound: max98927: Add reset-gpios optional property
commit: b23d3189c038c091adc8de382d20a8f5321645a1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark