Hi Luis,
next-20170705 fails to build on powerpc with below errors.
Machine Type: Power 8 Power VM Lpar
Kernel : 4.12.0-next-20170705
gcc : version 5.2.1
config: attached Tul-vm-config
drivers/i2c/busses/i2c-designware-platdrv.c: In function
‘dw_i2c_plat_probe’:
drivers/i2c/busses/i2c-designware-platdrv.c:331:6: error: implicit
declaration of function
‘i2c_detect_slave_mode’ [-Werror=implicit-function-declaration]
if (i2c_detect_slave_mode(&pdev->dev))
^
cc1: some warnings being treated as errors
make[3]: *** [drivers/i2c/busses/i2c-designware-platdrv.o] Error 1
In file drivers/i2c/busses/i2c-designware-platdrv.c
ret = i2c_dw_probe_lock_support(dev);
if (ret)
goto exit_reset;
>>> if (i2c_detect_slave_mode(&pdev->dev))
i2c_dw_configure_slave(dev);
else
i2c_dw_configure_master(dev);
dev->clk = devm_clk_get(&pdev->dev, NULL);
The line was first introduced with commit:
commit 5b6d721b266acaef411520e28066e4624c6619e7
Author: Luis Oliveira <[email protected]>
Date: Thu Jun 22 11:17:33 2017 +0100
i2c: designware: enable SLAVE in platform module
- Slave mode selected in platform module if the support is detected
in
the DT.
Signed-off-by: Luis Oliveira <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
Acked-by: Jarkko Nikula <[email protected]>
Signed-off-by: Wolfram Sang <[email protected]>
diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c
b/drivers/i2c/busses/i2c-designware-platdrv.c
index 1f38c80..2ea6d0d 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
--
Regard's
Abdul Haleem
IBM Linux Technology Centre
On Thu, Jul 6, 2017 at 9:00 AM, Abdul Haleem
<[email protected]> wrote:
> Hi Luis,
>
> next-20170705 fails to build on powerpc with below errors.
Hi,
I had sent a fix yesterday. Had you chance to test it?
--
With Best Regards,
Andy Shevchenko
On Fri, 2017-07-07 at 19:36 +0300, Andy Shevchenko wrote:
> On Thu, Jul 6, 2017 at 9:00 AM, Abdul Haleem
> <[email protected]> wrote:
> > Hi Luis,
> >
> > next-20170705 fails to build on powerpc with below errors.
>
> Hi,
>
> I had sent a fix yesterday. Had you chance to test it?
>
>
Are these the one you are referring to ?
[v1,2/2] ACPI / boot: Don't define unused variables
[v1,1/2] ACPI / boot: Correct address space of __acpi_map_table()
Applying above patches did not fix the build failure.
drivers/i2c/busses/i2c-designware-platdrv.c:331:6: error: implicit
declaration of function
‘i2c_detect_slave_mode’ [-Werror=implicit-function-declaration]
if (i2c_detect_slave_mode(&pdev->dev))
^
CC [M] fs/jffs2/scan.o
Please point me to the correct patch you are referring to ?
--
Regard's
Abdul Haleem
IBM Linux Technology Centre
On Mon, Jul 10, 2017 at 5:37 PM, Abdul Haleem
<[email protected]> wrote:
> On Fri, 2017-07-07 at 19:36 +0300, Andy Shevchenko wrote:
>> On Thu, Jul 6, 2017 at 9:00 AM, Abdul Haleem
>> <[email protected]> wrote:
>> > next-20170705 fails to build on powerpc with below errors.
>> I had sent a fix yesterday. Had you chance to test it?
> drivers/i2c/busses/i2c-designware-platdrv.c:331:6: error: implicit
> declaration of function
> ‘i2c_detect_slave_mode’ [-Werror=implicit-function-declaration]
> if (i2c_detect_slave_mode(&pdev->dev))
> ^
> CC [M] fs/jffs2/scan.o
>
> Please point me to the correct patch you are referring to ?
commit 8f1a357d41a22009150cf404b5aa5876efdb59b1
i2c: Provide a stub for i2c_detect_slave_mode()
--
With Best Regards,
Andy Shevchenko
On Mon, 2017-07-10 at 18:17 +0300, Andy Shevchenko wrote:
> On Mon, Jul 10, 2017 at 5:37 PM, Abdul Haleem
> <[email protected]> wrote:
> > On Fri, 2017-07-07 at 19:36 +0300, Andy Shevchenko wrote:
> >> On Thu, Jul 6, 2017 at 9:00 AM, Abdul Haleem
> >> <[email protected]> wrote:
> >> > next-20170705 fails to build on powerpc with below errors.
> >> I had sent a fix yesterday. Had you chance to test it?
>
> > drivers/i2c/busses/i2c-designware-platdrv.c:331:6: error: implicit
> > declaration of function
> > ‘i2c_detect_slave_mode’ [-Werror=implicit-function-declaration]
> > if (i2c_detect_slave_mode(&pdev->dev))
> > ^
> > CC [M] fs/jffs2/scan.o
> >
> > Please point me to the correct patch you are referring to ?
>
> commit 8f1a357d41a22009150cf404b5aa5876efdb59b1
>
> i2c: Provide a stub for i2c_detect_slave_mode()
>
Thanks Andy for the fix, the patch fixes the build errors.
Machine booted with no issues.
Reported-and-tested-by: Abdul Haleem <[email protected]>
--
Regard's
Abdul Haleem
IBM Linux Technology Centre