2022-02-02 11:03:03

by Joel Stanley

[permalink] [raw]
Subject: Re: [PATCH v5 0/9] Nuvoton WPCM450 pinctrl and GPIO driver

On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <[email protected]> wrote:
>
> On Sun, Jan 30, 2022 at 02:50:25AM +0100, Linus Walleij wrote:
> > On Sat, Jan 29, 2022 at 12:57 PM Jonathan Neuschäfer
> > <[email protected]> wrote:
> >
> > > This is version 5 of the WPCM450 pinctrl/GPIO driver patchset.

> > Which patches do you expect to be applied to the pin control tree?
>
> These two:
>
> [PATCH v5 4/9] dt-bindings: pinctrl: Add Nuvoton WPCM450
> [PATCH v5 5/9] pinctrl: nuvoton: Add driver for WPCM450
>
> and the rest can go through Joel Stanley's BMC tree, I think.

Seems reasonable. I assume you're sending a v6 to fix some of the warnings?

Cheers,

Joel


2022-02-02 12:56:35

by J. Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH v5 0/9] Nuvoton WPCM450 pinctrl and GPIO driver

On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote:
> On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <[email protected]> wrote:
> >
> > On Sun, Jan 30, 2022 at 02:50:25AM +0100, Linus Walleij wrote:
> > > On Sat, Jan 29, 2022 at 12:57 PM Jonathan Neuschäfer
> > > <[email protected]> wrote:
> > >
> > > > This is version 5 of the WPCM450 pinctrl/GPIO driver patchset.
>
> > > Which patches do you expect to be applied to the pin control tree?
> >
> > These two:
> >
> > [PATCH v5 4/9] dt-bindings: pinctrl: Add Nuvoton WPCM450
> > [PATCH v5 5/9] pinctrl: nuvoton: Add driver for WPCM450
> >
> > and the rest can go through Joel Stanley's BMC tree, I think.
>
> Seems reasonable. I assume you're sending a v6 to fix some of the warnings?

No, the warnings are fairly independent of this patchset, it's just that
the adjacent pinctrl-npcm7xx driver started to be built by the bot, due
to my Kconfig change. I'll fix them in a separate patchset.


Jonathan


Attachments:
(No filename) (0.98 kB)
signature.asc (849.00 B)
Download all attachments

2022-02-02 18:38:28

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v5 0/9] Nuvoton WPCM450 pinctrl and GPIO driver

On Wed, Feb 2, 2022 at 2:01 PM Jonathan Neuschäfer
<[email protected]> wrote:
> On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote:
> > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <[email protected]> wrote:

...

> > I assume you're sending a v6 to fix some of the warnings?
>
> No, the warnings are fairly independent of this patchset, it's just that
> the adjacent pinctrl-npcm7xx driver started to be built by the bot, due
> to my Kconfig change. I'll fix them in a separate patchset.

I guess you need to fix that first.

Because now and then all CIs will complain to your patch and confuse people.

--
With Best Regards,
Andy Shevchenko

2022-02-14 09:59:58

by J. Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH v5 0/9] Nuvoton WPCM450 pinctrl and GPIO driver

On Wed, Feb 02, 2022 at 02:10:44PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 2, 2022 at 2:01 PM Jonathan Neuschäfer
> <[email protected]> wrote:
> > On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote:
> > > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <[email protected]> wrote:
>
> ...
>
> > > I assume you're sending a v6 to fix some of the warnings?
> >
> > No, the warnings are fairly independent of this patchset, it's just that
> > the adjacent pinctrl-npcm7xx driver started to be built by the bot, due
> > to my Kconfig change. I'll fix them in a separate patchset.
>
> I guess you need to fix that first.
>
> Because now and then all CIs will complain to your patch and confuse people.

FWIW, Linus has applied the npcm7xx fixes to for-next in the pinctrl tree,
which means that they are not blocking this patchset anymore, AFAICS.


Jonathan


Attachments:
(No filename) (905.00 B)
signature.asc (849.00 B)
Download all attachments

2022-02-15 06:24:07

by Joel Stanley

[permalink] [raw]
Subject: Re: [PATCH v5 0/9] Nuvoton WPCM450 pinctrl and GPIO driver

On Mon, 14 Feb 2022 at 12:05, Jonathan Neuschäfer <[email protected]> wrote:
>
> On Wed, Feb 02, 2022 at 02:10:44PM +0200, Andy Shevchenko wrote:
> > On Wed, Feb 2, 2022 at 2:01 PM Jonathan Neuschäfer
> > <[email protected]> wrote:
> > > On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote:
> > > > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <[email protected]> wrote:
> >
> > ...
> >
> > > > I assume you're sending a v6 to fix some of the warnings?
> > >
> > > No, the warnings are fairly independent of this patchset, it's just that
> > > the adjacent pinctrl-npcm7xx driver started to be built by the bot, due
> > > to my Kconfig change. I'll fix them in a separate patchset.
> >
> > I guess you need to fix that first.
> >
> > Because now and then all CIs will complain to your patch and confuse people.
>
> FWIW, Linus has applied the npcm7xx fixes to for-next in the pinctrl tree,
> which means that they are not blocking this patchset anymore, AFAICS.

I've applied the device tree changes, and I will send a pull request
for v5.18 with those.

I assume you want Linus to merge the pinctrl bindings and driver
through his tree.

Cheers,

Joel

2022-02-15 18:29:35

by J. Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH v5 0/9] Nuvoton WPCM450 pinctrl and GPIO driver

On Tue, Feb 15, 2022 at 05:56:17AM +0000, Joel Stanley wrote:
> On Mon, 14 Feb 2022 at 12:05, Jonathan Neuschäfer <[email protected]> wrote:
> >
> > On Wed, Feb 02, 2022 at 02:10:44PM +0200, Andy Shevchenko wrote:
> > > On Wed, Feb 2, 2022 at 2:01 PM Jonathan Neuschäfer
> > > <[email protected]> wrote:
> > > > On Tue, Feb 01, 2022 at 11:42:11PM +0000, Joel Stanley wrote:
> > > > > On Tue, 1 Feb 2022 at 13:05, Jonathan Neuschäfer <[email protected]> wrote:
> > >
> > > ...
> > >
> > > > > I assume you're sending a v6 to fix some of the warnings?
> > > >
> > > > No, the warnings are fairly independent of this patchset, it's just that
> > > > the adjacent pinctrl-npcm7xx driver started to be built by the bot, due
> > > > to my Kconfig change. I'll fix them in a separate patchset.
> > >
> > > I guess you need to fix that first.
> > >
> > > Because now and then all CIs will complain to your patch and confuse people.
> >
> > FWIW, Linus has applied the npcm7xx fixes to for-next in the pinctrl tree,
> > which means that they are not blocking this patchset anymore, AFAICS.
>
> I've applied the device tree changes, and I will send a pull request
> for v5.18 with those.

Thanks!


> I assume you want Linus to merge the pinctrl bindings and driver
> through his tree.

Yes, that sounds alright.


Jonathan


Attachments:
(No filename) (1.33 kB)
signature.asc (849.00 B)
Download all attachments