After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
satisfied implicitly through dependencies on CONFIG_ACPI have to be
specified directly. This driver depends on the PCI infrastructure but
the dependency has not been explicitly called out.
Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
Signed-off-by: Sinan Kaya <[email protected]>
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 7afb96cb1cd6..89f4b86244a7 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
config APPLE_GMUX
tristate "Apple Gmux Driver"
depends on ACPI
+ depends on PCI
depends on PNP
depends on BACKLIGHT_CLASS_DEVICE
depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
--
2.19.0
On Wed, Jan 02, 2019 at 06:10:33PM +0000, Sinan Kaya wrote:
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver depends on the PCI infrastructure but
> the dependency has not been explicitly called out.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <[email protected]>
Reviewed-by: Lukas Wunner <[email protected]>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 7afb96cb1cd6..89f4b86244a7 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
> config APPLE_GMUX
> tristate "Apple Gmux Driver"
> depends on ACPI
> + depends on PCI
> depends on PNP
> depends on BACKLIGHT_CLASS_DEVICE
> depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
> --
> 2.19.0
On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya <[email protected]> wrote:
>
> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> satisfied implicitly through dependencies on CONFIG_ACPI have to be
> specified directly. This driver depends on the PCI infrastructure but
> the dependency has not been explicitly called out.
>
> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> Signed-off-by: Sinan Kaya <[email protected]>
> ---
> drivers/platform/x86/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 7afb96cb1cd6..89f4b86244a7 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
> config APPLE_GMUX
> tristate "Apple Gmux Driver"
> depends on ACPI
> + depends on PCI
Can you stick with the same pattern you have used for the rest in this series?
I.e.
depends on ACPI && PCI
> depends on PNP
> depends on BACKLIGHT_CLASS_DEVICE
> depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
> --
> 2.19.0
>
--
With Best Regards,
Andy Shevchenko
On Fri, Jan 4, 2019 at 4:12 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Wed, Jan 2, 2019 at 8:10 PM Sinan Kaya <[email protected]> wrote:
> >
> > After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
> > CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
> > satisfied implicitly through dependencies on CONFIG_ACPI have to be
> > specified directly. This driver depends on the PCI infrastructure but
> > the dependency has not been explicitly called out.
> >
> > Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
> > Signed-off-by: Sinan Kaya <[email protected]>
> > ---
> > drivers/platform/x86/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 7afb96cb1cd6..89f4b86244a7 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1136,6 +1136,7 @@ config SAMSUNG_Q10
> > config APPLE_GMUX
> > tristate "Apple Gmux Driver"
>
> > depends on ACPI
> > + depends on PCI
>
> Can you stick with the same pattern you have used for the rest in this series?
> I.e.
> depends on ACPI && PCI
After satisfying it
Reviewed-by: Andy Shevchenko <[email protected]>
Acked-by: Andy Shevchenko <[email protected]>
>
>
> > depends on PNP
> > depends on BACKLIGHT_CLASS_DEVICE
> > depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
> > --
> > 2.19.0
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko