This patch fix the following build error on M68K:
drivers/tty/serial/8250/8250_dw.o: In function `dw8250_set_termios':
8250_dw.c:(.text+0x50c): undefined reference to `clk_round_rate'
8250_dw.c:(.text+0x594): undefined reference to `clk_set_rate'
So 8250_dw need to depend on COMMON_CLK.
Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/tty/serial/8250/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index f005eaf8bc57..37d4ec5f3cc9 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -351,7 +351,7 @@ config SERIAL_8250_FSL
config SERIAL_8250_DW
tristate "Support for Synopsys DesignWare 8250 quirks"
- depends on SERIAL_8250
+ depends on SERIAL_8250 && COMMON_CLK
help
Selecting this option will enable handling of the extra features
present in the Synopsys DesignWare APB UART.
--
2.16.4
On Wed, Jun 6, 2018 at 10:27 PM Corentin Labbe <[email protected]> wrote:
>
> This patch fix the following build error on M68K:
> drivers/tty/serial/8250/8250_dw.o: In function `dw8250_set_termios':
> 8250_dw.c:(.text+0x50c): undefined reference to `clk_round_rate'
> 8250_dw.c:(.text+0x594): undefined reference to `clk_set_rate'
>
> So 8250_dw need to depend on COMMON_CLK.
>
Makes sense.
Reviewed-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> drivers/tty/serial/8250/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index f005eaf8bc57..37d4ec5f3cc9 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -351,7 +351,7 @@ config SERIAL_8250_FSL
>
> config SERIAL_8250_DW
> tristate "Support for Synopsys DesignWare 8250 quirks"
> - depends on SERIAL_8250
> + depends on SERIAL_8250 && COMMON_CLK
> help
> Selecting this option will enable handling of the extra features
> present in the Synopsys DesignWare APB UART.
> --
> 2.16.4
>
--
With Best Regards,
Andy Shevchenko
On Mon, Jun 11, 2018 at 11:03 PM Andy Shevchenko
<[email protected]> wrote:
> On Wed, Jun 6, 2018 at 10:27 PM Corentin Labbe <[email protected]> wrote:
> > This patch fix the following build error on M68K:
Not plain m68k, but coldfire only (and MIPS AR7, I guess).
> > drivers/tty/serial/8250/8250_dw.o: In function `dw8250_set_termios':
> > 8250_dw.c:(.text+0x50c): undefined reference to `clk_round_rate'
> > 8250_dw.c:(.text+0x594): undefined reference to `clk_set_rate'
> >
> > So 8250_dw need to depend on COMMON_CLK.
> >
>
> Makes sense.
> Reviewed-by: Andy Shevchenko <[email protected]>
Please see "[PATCH 0/3] Legacy clock drivers: Normalize clk API"
(https://lkml.org/lkml/2018/6/11/122).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Tue, Jun 12, 2018 at 11:31 AM, Geert Uytterhoeven
<[email protected]> wrote:
> On Mon, Jun 11, 2018 at 11:03 PM Andy Shevchenko
> <[email protected]> wrote:
>> On Wed, Jun 6, 2018 at 10:27 PM Corentin Labbe <[email protected]> wrote:
>> > This patch fix the following build error on M68K:
>
> Not plain m68k, but coldfire only (and MIPS AR7, I guess).
>
>> > drivers/tty/serial/8250/8250_dw.o: In function `dw8250_set_termios':
>> > 8250_dw.c:(.text+0x50c): undefined reference to `clk_round_rate'
>> > 8250_dw.c:(.text+0x594): undefined reference to `clk_set_rate'
>> >
>> > So 8250_dw need to depend on COMMON_CLK.
>> >
>>
>> Makes sense.
>> Reviewed-by: Andy Shevchenko <[email protected]>
>
> Please see "[PATCH 0/3] Legacy clock drivers: Normalize clk API"
> (https://lkml.org/lkml/2018/6/11/122).
Indeed, your solution is better.
So, I need to withdraw my tag.
--
With Best Regards,
Andy Shevchenko