2022-05-06 15:29:20

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v7 0/2] Make AUX gpio pin optional for ktd2692

On Wed, May 4, 2022 at 9:35 PM Markuss Broks <[email protected]> wrote:
>
> Some appliances of ktd2692 don't have the AUX pin connected to
> a GPIO. Specifically, Samsung Galaxy J5 (2015), which uses ktd2692
> for driving the front flash LED, has the pin not connected anywhere on
> schematics. Make specifying the AUX pin optional, since it is additional
> functionality and only affects amount of current going through the LED.

the amount

> Also convert the txt device-tree bindings to yaml and pick up maintenance
> over the yaml binding and the driver itself.

...

> v7:
> - drop the MAINTAINERS part

I'm not sure why it happened.

What I mentioned is to create a series out of 4 (four) patches:
1) fix the potential issue with the repetitive message;
2) update DT;
3) switch to optional GPIO;
4) update MAINTAINERS.


--
With Best Regards,
Andy Shevchenko


2022-05-07 10:43:59

by Markuss Broks

[permalink] [raw]
Subject: Re: [PATCH v7 0/2] Make AUX gpio pin optional for ktd2692

Hi Andy,

On 5/4/22 22:44, Andy Shevchenko wrote:
> On Wed, May 4, 2022 at 9:35 PM Markuss Broks <[email protected]> wrote:
>> Some appliances of ktd2692 don't have the AUX pin connected to
>> a GPIO. Specifically, Samsung Galaxy J5 (2015), which uses ktd2692
>> for driving the front flash LED, has the pin not connected anywhere on
>> schematics. Make specifying the AUX pin optional, since it is additional
>> functionality and only affects amount of current going through the LED.
> the amount
>
>> Also convert the txt device-tree bindings to yaml and pick up maintenance
>> over the yaml binding and the driver itself.
> ...
>
>> v7:
>> - drop the MAINTAINERS part
> I'm not sure why it happened.
Pavel asked me to drop the MAINTAINERS part for now.
>
> What I mentioned is to create a series out of 4 (four) patches:
> 1) fix the potential issue with the repetitive message;
Bummer, totally forgot about that, thank you for a reminder!
> 2) update DT;
> 3) switch to optional GPIO;
> 4) update MAINTAINERS.
>
>
- Markuss