2023-08-09 18:07:56

by coolrrsh

Subject: [PATCH] gpio: gpio-imx-scu: Use ARRAY_SIZE for array length

From: Rajeshwar R Shinde <[email protected]>

Use of macro ARRAY_SIZE to calculate array size minimizes
the redundant code and improves code reusability.
This fixes warnings reported by Coccinelle:
drivers/gpio/gpio-imx-scu.c:106:32-33: WARNING: Use ARRAY_SIZE

Signed-off-by: Rajeshwar R Shinde <[email protected]>
---
drivers/gpio/gpio-imx-scu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-imx-scu.c b/drivers/gpio/gpio-imx-scu.c
index e190bde5397d..fb05a53c9712 100644
--- a/drivers/gpio/gpio-imx-scu.c
+++ b/drivers/gpio/gpio-imx-scu.c
@@ -103,7 +103,7 @@ static int imx_scu_gpio_probe(struct platform_device *pdev)
gc = &priv->chip;
gc->base = -1;
gc->parent = dev;
- gc->ngpio = sizeof(scu_rsrc_arr)/sizeof(unsigned int);
+ gc->ngpio = ARRAY_SIZE(scu_rsrc_arr)/sizeof(unsigned int);
gc->label = dev_name(dev);
gc->get = imx_scu_gpio_get;
gc->set = imx_scu_gpio_set;
--
2.25.1

2023-08-10 07:39:58

by Khalid Masum

Subject: Re: [PATCH] gpio: gpio-imx-scu: Use ARRAY_SIZE for array length

On Wed, Aug 9, 2023 at 11:12 PM <[email protected]> wrote:
>
> From: Rajeshwar R Shinde <[email protected]>
>
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
> This fixes warnings reported by Coccinelle:
> drivers/gpio/gpio-imx-scu.c:106:32-33: WARNING: Use ARRAY_SIZE
>
> Signed-off-by: Rajeshwar R Shinde <[email protected]>
> ---
> drivers/gpio/gpio-imx-scu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-imx-scu.c b/drivers/gpio/gpio-imx-scu.c
> index e190bde5397d..fb05a53c9712 100644
> --- a/drivers/gpio/gpio-imx-scu.c
> +++ b/drivers/gpio/gpio-imx-scu.c
> @@ -103,7 +103,7 @@ static int imx_scu_gpio_probe(struct platform_device *pdev)
> gc = &priv->chip;
> gc->base = -1;
> gc->parent = dev;
> - gc->ngpio = sizeof(scu_rsrc_arr)/sizeof(unsigned int);
> + gc->ngpio = ARRAY_SIZE(scu_rsrc_arr)/sizeof(unsigned int);
Since ARRAY_SIZE is being used, no need to divide it with sizeof unsigned int
again.
...
gc->ngpio = ARRAY_SIZE(scu_rsrc_arr);
...

> gc->label = dev_name(dev);
> gc->get = imx_scu_gpio_get;
> gc->set = imx_scu_gpio_set;
> --
> 2.25.1

thanks,
-- Khalid Masum

2023-08-10 11:20:11

by Andy Shevchenko

Subject: Re: [PATCH] gpio: gpio-imx-scu: Use ARRAY_SIZE for array length

On Wed, Aug 9, 2023 at 8:12 PM <[email protected]> wrote:
>
> From: Rajeshwar R Shinde <[email protected]>
>
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
> This fixes warnings reported by Coccinelle:
> drivers/gpio/gpio-imx-scu.c:106:32-33: WARNING: Use ARRAY_SIZE

Can you test your changes, please?
We don't want just mechanical (scripted) conversion with obviously
wrong results.

NAK.

--
With Best Regards,
Andy Shevchenko