2023-10-02 22:15:53

by Andy Shevchenko

Subject: Re: [PATCH v4 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver

On Mon, Oct 2, 2023 at 10:41 PM Tomer Maimon <[email protected]> wrote:
>
> Add Nuvoton NPCM BMC sdhci-pltfm controller driver.

...

> + pltfm_host->clk = devm_clk_get_optional_enabled(dev, NULL);
> + if (IS_ERR(pltfm_host->clk)) {
> + ret = PTR_ERR(pltfm_host->clk);
> + goto err_sdhci;
> + }

...

> +err_sdhci_clk:
> + clk_disable_unprepare(pltfm_host->clk);

Now this is leftover that leads to unbalanced reference counting.

--
With Best Regards,
Andy Shevchenko

2023-10-02 22:45:48

by Tomer Maimon

Subject: Re: [PATCH v4 2/2] mmc: sdhci-npcm: Add NPCM SDHCI driver

Hi Andy

Thank a lot Address in V5

On Mon, 2 Oct 2023 at 22:46, Andy Shevchenko <[email protected]> wrote:
>
> On Mon, Oct 2, 2023 at 10:41 PM Tomer Maimon <[email protected]> wrote:
> >
> > Add Nuvoton NPCM BMC sdhci-pltfm controller driver.
>
> ...
>
> > + pltfm_host->clk = devm_clk_get_optional_enabled(dev, NULL);
> > + if (IS_ERR(pltfm_host->clk)) {
> > + ret = PTR_ERR(pltfm_host->clk);
> > + goto err_sdhci;
> > + }
>
> ...
>
> > +err_sdhci_clk:
> > + clk_disable_unprepare(pltfm_host->clk);
>
> Now this is leftover that leads to unbalanced reference counting.
>
> --
> With Best Regards,
> Andy Shevchenko