dev_comp field is used in a couple of places but it is never set. This
results in kernel oops when dereferencing a NULL pointer. Set the
`dev_comp` field correctly in the probe function.
Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
Signed-off-by: Fabien Parent <[email protected]>
---
Changelog:
V2:
* s/of_device_get_match_data/device_get_match_data
* include mod_devicetable.h and property.h instead of of_*.h headers
drivers/iio/adc/mt6577_auxadc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
index ac415cb089cd..79c1dd68b909 100644
--- a/drivers/iio/adc/mt6577_auxadc.c
+++ b/drivers/iio/adc/mt6577_auxadc.c
@@ -9,9 +9,9 @@
#include <linux/err.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
+#include <linux/mod_devicetable.h>
#include <linux/platform_device.h>
+#include <linux/property.h>
#include <linux/iopoll.h>
#include <linux/io.h>
#include <linux/iio/iio.h>
@@ -276,6 +276,8 @@ static int mt6577_auxadc_probe(struct platform_device *pdev)
goto err_disable_clk;
}
+ adc_dev->dev_comp = device_get_match_data(&pdev->dev);
+
mutex_init(&adc_dev->lock);
mt6577_auxadc_mod_reg(adc_dev->reg_base + MT6577_AUXADC_MISC,
--
2.28.0
On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent <[email protected]> wrote:
>
> dev_comp field is used in a couple of places but it is never set. This
> results in kernel oops when dereferencing a NULL pointer. Set the
> `dev_comp` field correctly in the probe function.
>
> Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
>
> Signed-off-by: Fabien Parent <[email protected]>
Shouldn't be a blank line in the tag block.
I think Jonathan can fix it, but be more careful in the future.
--
With Best Regards,
Andy Shevchenko
On Sun, Oct 18, 2020 at 9:31 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent <[email protected]> wrote:
> >
> > dev_comp field is used in a couple of places but it is never set. This
> > results in kernel oops when dereferencing a NULL pointer. Set the
> > `dev_comp` field correctly in the probe function.
> >
> > Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
> >
> > Signed-off-by: Fabien Parent <[email protected]>
>
> Shouldn't be a blank line in the tag block.
>
> I think Jonathan can fix it, but be more careful in the future.
One more serious issue, you forgot to add tags you have gotten in the
previous round.
--
With Best Regards,
Andy Shevchenko
Hi Andy
On Sun, Oct 18, 2020 at 8:33 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Sun, Oct 18, 2020 at 9:31 PM Andy Shevchenko
> <[email protected]> wrote:
> >
> > On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent <[email protected]> wrote:
> > >
> > > dev_comp field is used in a couple of places but it is never set. This
> > > results in kernel oops when dereferencing a NULL pointer. Set the
> > > `dev_comp` field correctly in the probe function.
> > >
> > > Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
> > >
> > > Signed-off-by: Fabien Parent <[email protected]>
> >
> > Shouldn't be a blank line in the tag block.
> >
> > I think Jonathan can fix it, but be more careful in the future.
>
> One more serious issue, you forgot to add tags you have gotten in the
> previous round.
Thanks for the review. I will make it easy for the maintainer and send
right away a v3 that fixes both issues you pointed out.
> --
> With Best Regards,
> Andy Shevchenko