2022-09-05 07:19:00

by Dmitry Torokhov

Subject: [PATCH v1 08/11] regulator: bd71815: switch to using devm_fwnode_gpiod_get()

I would like to stop exporting OF-specific devm_gpiod_get_from_of_node()
so that gpiolib can be cleaned a bit, so let's switch to the generic
fwnode property API.

Signed-off-by: Dmitry Torokhov <[email protected]>

diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c
index acaa6607898e..c2b8b8be7824 100644
--- a/drivers/regulator/bd71815-regulator.c
+++ b/drivers/regulator/bd71815-regulator.c
@@ -571,11 +571,10 @@ static int bd7181x_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "No parent regmap\n");
return -ENODEV;
}
- ldo4_en = devm_gpiod_get_from_of_node(&pdev->dev,
- pdev->dev.parent->of_node,
- "rohm,vsel-gpios", 0,
- GPIOD_ASIS, "ldo4-en");

+ ldo4_en = devm_fwnode_gpiod_get(&pdev->dev,
+ dev_fwnode(pdev->dev.parent),
+ "rohm,vsel", GPIOD_ASIS, "ldo4-en");
if (IS_ERR(ldo4_en)) {
ret = PTR_ERR(ldo4_en);
if (ret != -ENOENT)

--
b4 0.10.0-dev-fc921

2022-09-05 10:17:26

by Matti Vaittinen

Subject: Re: [PATCH v1 08/11] regulator: bd71815: switch to using devm_fwnode_gpiod_get()

On 9/5/22 09:31, Dmitry Torokhov wrote:
> I would like to stop exporting OF-specific devm_gpiod_get_from_of_node()
> so that gpiolib can be cleaned a bit, so let's switch to the generic
> fwnode property API.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>

Reviewed-by: Matti Vaittinen <[email protected]>

>
> diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c
> index acaa6607898e..c2b8b8be7824 100644
> --- a/drivers/regulator/bd71815-regulator.c
> +++ b/drivers/regulator/bd71815-regulator.c
> @@ -571,11 +571,10 @@ static int bd7181x_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "No parent regmap\n");
> return -ENODEV;
> }
> - ldo4_en = devm_gpiod_get_from_of_node(&pdev->dev,
> - pdev->dev.parent->of_node,
> - "rohm,vsel-gpios", 0,
> - GPIOD_ASIS, "ldo4-en");
>
> + ldo4_en = devm_fwnode_gpiod_get(&pdev->dev,
> + dev_fwnode(pdev->dev.parent),
> + "rohm,vsel", GPIOD_ASIS, "ldo4-en");
> if (IS_ERR(ldo4_en)) {
> ret = PTR_ERR(ldo4_en);
> if (ret != -ENOENT)
>


--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

2022-09-05 11:13:32

by Andy Shevchenko

Subject: Re: [PATCH v1 08/11] regulator: bd71815: switch to using devm_fwnode_gpiod_get()

On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov
<[email protected]> wrote:
>
> I would like to stop exporting OF-specific devm_gpiod_get_from_of_node()
> so that gpiolib can be cleaned a bit, so let's switch to the generic
> fwnode property API.

Special thanks for using dev_fwnode().
Reviewed-by: Andy Shevchenko <[email protected]>
(Dunno if my suggestion about parent applies here)

> Signed-off-by: Dmitry Torokhov <[email protected]>
>
> diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c
> index acaa6607898e..c2b8b8be7824 100644
> --- a/drivers/regulator/bd71815-regulator.c
> +++ b/drivers/regulator/bd71815-regulator.c
> @@ -571,11 +571,10 @@ static int bd7181x_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "No parent regmap\n");
> return -ENODEV;
> }
> - ldo4_en = devm_gpiod_get_from_of_node(&pdev->dev,
> - pdev->dev.parent->of_node,
> - "rohm,vsel-gpios", 0,
> - GPIOD_ASIS, "ldo4-en");
>
> + ldo4_en = devm_fwnode_gpiod_get(&pdev->dev,
> + dev_fwnode(pdev->dev.parent),
> + "rohm,vsel", GPIOD_ASIS, "ldo4-en");
> if (IS_ERR(ldo4_en)) {
> ret = PTR_ERR(ldo4_en);
> if (ret != -ENOENT)
>
> --
> b4 0.10.0-dev-fc921



--
With Best Regards,
Andy Shevchenko

2022-09-08 09:09:06

by Linus Walleij

Subject: Re: [PATCH v1 08/11] regulator: bd71815: switch to using devm_fwnode_gpiod_get()

On Mon, Sep 5, 2022 at 8:31 AM Dmitry Torokhov
<[email protected]> wrote:

> I would like to stop exporting OF-specific devm_gpiod_get_from_of_node()
> so that gpiolib can be cleaned a bit, so let's switch to the generic
> fwnode property API.
>
> Signed-off-by: Dmitry Torokhov <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij