Hi all,
Commit
ec702fa79702 ("gfs2: Dump nrpages for inodes and their glocks")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
Hi all,
On Wed, 12 Dec 2018 07:24:02 +1100 Stephen Rothwell <[email protected]> wrote:
>
> Commit
>
> ec702fa79702 ("gfs2: Dump nrpages for inodes and their glocks")
>
> is missing a Signed-off-by from its committer.
Now, after the rebase:
Commits
187e4dad3f55 ("gfs2: Remove vestigial bd_ops")
is missing a Signed-off-by from its committer.
--
Cheers,
Stephen Rothwell
Hi,
Am Di., 11. Dez. 2018 um 21:40 Uhr schrieb Stephen Rothwell
<[email protected]>:
> Hi all,
>
> On Wed, 12 Dec 2018 07:24:02 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > Commit
> >
> > ec702fa79702 ("gfs2: Dump nrpages for inodes and their glocks")
> >
> > is missing a Signed-off-by from its committer.
>
> Now, after the rebase:
>
> Commits
>
> 187e4dad3f55 ("gfs2: Remove vestigial bd_ops")
>
> is missing a Signed-off-by from its committer.
Yep, I've not asked for a way to get the server to reject or warn
about such pushes without a reason.
Thanks,
Andreas
Hi Andreas,
On Tue, 11 Dec 2018 21:47:43 +0100 Andreas Grünbacher <[email protected]> wrote:
>
> Yep, I've not asked for a way to get the server to reject or warn
> about such pushes without a reason.
Sure, but also here's the script I run (which could be run before
pushing) ...
----------------------------------------------------------------------
#!/bin/bash
if [ "$#" -lt 1 ]; then
printf "Usage: %s <commit range>\n", "$0" 1>&2
exit 1
fi
commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
printf "No commits\n"
exit 0
fi
author_missing=
committer_missing=
print_commits()
{
local t="$1"
shift
s=
is='is'
its='its'
[ "$#" -gt 1 ] && {
s='s'
is='are'
its='their'
}
printf "Commit%s\n\n" "$s"
git log --no-walk --pretty='format: %h ("%s")' "$@"
printf "\n%s missing a Signed-off-by from %s %s%s.\n" "$is" "$its" "$t" "$s"
printf "\n"
}
for c in $commits; do
ae=$(git log -1 --format='<%ae>%n<%aE>%n %an %n %aN ' "$c" | sort -u)
ce=$(git log -1 --format='<%ce>%n<%cE>%n %cn %n %cN ' "$c" | sort -u)
msg=$(git log -1 --format='%b' "$c")
sob=$(echo "$msg" | sed -En 's/^\s*Signed-off-by:?\s*/ /ip')
am=false
cm=false
grep -i -F -q "$ae" <<<"$sob" ||
am=true
grep -i -F -q "$ce" <<<"$sob" ||
cm=true
"$am" && author_missing+=" $c"
"$cm" && committer_missing+=" $c"
done
if [ "$author_missing" ]; then
print_commits "author" $author_missing
fi
if [ "$committer_missing" ]; then
print_commits "committer" $committer_missing
fi
----------------------------------------------------------------------
--
Cheers,
Stephen Rothwell
On Tue, Dec 11, 2018 at 09:47:43PM +0100, Andreas Grünbacher wrote:
> > Now, after the rebase:
> >
> > Commits
> >
> > 187e4dad3f55 ("gfs2: Remove vestigial bd_ops")
> >
> > is missing a Signed-off-by from its committer.
>
> Yep, I've not asked for a way to get the server to reject or warn
> about such pushes without a reason.
We don't run checks on push that involve iterating through commits,
because most of the pushes we receive are merges and rejecting on a
commit somewhere deep in an octopus merge would just result in angry
maintainers.
Best,
-K