2021-10-19 22:25:02

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the gfs2 tree

Hi all,

After merging the gfs2 tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from fs/gfs2/glock.c:39:
fs/gfs2/glock.c: In function 'may_grant':
fs/gfs2/glock.c:332:16: error: passing argument 2 of 'gfs2_dump_glock' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
332 | GLOCK_BUG_ON(gl, !test_bit(HIF_HOLDER,
| ^~
fs/gfs2/glock.h:222:26: note: in definition of macro 'GLOCK_BUG_ON'
222 | gfs2_dump_glock(NULL, gl, true); \
| ^~
fs/gfs2/glock.h:219:70: note: expected 'struct gfs2_glock *' but argument is of type 'const struct gfs2_glock *'
219 | extern void gfs2_dump_glock(struct seq_file *seq, struct gfs2_glock *gl,
| ~~~~~~~~~~~~~~~~~~~^~
cc1: all warnings being treated as errors

Caused by commit

9d0f1e82baf2 ("gfs2: Introduce flag for glock holder auto-demotion")

I have used the gfs2 tree from next-20211019 for today.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-10-19 23:23:36

by Andreas Grünbacher

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the gfs2 tree

Hi Stephen,

Am Mi., 20. Okt. 2021 um 00:23 Uhr schrieb Stephen Rothwell
<[email protected]>:
> Hi all,
>
> [expected 'struct gfs2_glock *' but argument is of type 'const struct gfs2_glock *']

fixed now. Sorry for the mess.

Thanks,
Andreas