2019-12-10 23:11:09

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: build warning after merge of the gfs2 tree

---

Hi all,

After merging the gfs2 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

fs/gfs2/lops.c: In function 'gfs2_find_jhead':
fs/gfs2/lops.c:536:13: warning: 'bio_chained' may be used uninitialized in this function [-Wmaybe-uninitialized]
536 | if (!bio || (bio_chained && !off)) {
| ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

1ee366c67176 ("gfs2: Another gfs2_find_jhead fix")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2019-12-10 23:22:19

by Andreas Grünbacher

[permalink] [raw]

Subject: Re: linux-next: build warning after merge of the gfs2 tree

---

Hi Stephen,

Am Mi., 11. Dez. 2019 um 00:10 Uhr schrieb Stephen Rothwell
<[email protected]>:
> Hi all,
>
> After merging the gfs2 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> fs/gfs2/lops.c: In function 'gfs2_find_jhead':
> fs/gfs2/lops.c:536:13: warning: 'bio_chained' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 536 | if (!bio || (bio_chained && !off)) {
> | ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
>
> Introduced by commit
>
> 1ee366c67176 ("gfs2: Another gfs2_find_jhead fix")

thanks. It's actually a false positive and I'm not getting this
warning, but I'll make the code more explicit.

Andreas