2012-08-24 15:27:47

by Fengguang Wu

Subject: [PATCH] megaraid_sas: combine kmalloc+memset into kzalloc

Use kzalloc rather than kmalloc followed by memset with 0.

Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

Signed-off-by: Fengguang Wu <[email protected]>
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

--- linux.orig/drivers/scsi/megaraid/megaraid_sas_fusion.c 2012-06-07 05:39:57.418846382 +0800
+++ linux/drivers/scsi/megaraid/megaraid_sas_fusion.c 2012-08-24 23:25:02.261560445 +0800
@@ -461,8 +461,8 @@ megasas_alloc_cmds_fusion(struct megasas
* Allocate the dynamic array first and then allocate individual
* commands.
*/
- fusion->cmd_list = kmalloc(sizeof(struct megasas_cmd_fusion *)
- *max_cmd, GFP_KERNEL);
+ fusion->cmd_list = kzalloc(sizeof(struct megasas_cmd_fusion *)
+ * max_cmd, GFP_KERNEL);

if (!fusion->cmd_list) {
printk(KERN_DEBUG "megasas: out of memory. Could not alloc "
@@ -470,9 +470,6 @@ megasas_alloc_cmds_fusion(struct megasas
goto fail_cmd_list;
}

- memset(fusion->cmd_list, 0, sizeof(struct megasas_cmd_fusion *)
- *max_cmd);
-
max_cmd = instance->max_fw_cmds;
for (i = 0; i < max_cmd; i++) {
fusion->cmd_list[i] = kmalloc(sizeof(struct megasas_cmd_fusion),

2012-08-24 16:30:19

by adam radford

Subject: Re: [PATCH] megaraid_sas: combine kmalloc+memset into kzalloc

On Fri, Aug 24, 2012 at 8:27 AM, Fengguang Wu <[email protected]> wrote:
> Use kzalloc rather than kmalloc followed by memset with 0.
>
> Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
>
> Signed-off-by: Fengguang Wu <[email protected]>
> ---
> drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> --- linux.orig/drivers/scsi/megaraid/megaraid_sas_fusion.c 2012-06-07 05:39:57.418846382 +0800
> +++ linux/drivers/scsi/megaraid/megaraid_sas_fusion.c 2012-08-24 23:25:02.261560445 +0800
> @@ -461,8 +461,8 @@ megasas_alloc_cmds_fusion(struct megasas
> * Allocate the dynamic array first and then allocate individual
> * commands.
> */
> - fusion->cmd_list = kmalloc(sizeof(struct megasas_cmd_fusion *)
> - *max_cmd, GFP_KERNEL);
> + fusion->cmd_list = kzalloc(sizeof(struct megasas_cmd_fusion *)
> + * max_cmd, GFP_KERNEL);
>
> if (!fusion->cmd_list) {
> printk(KERN_DEBUG "megasas: out of memory. Could not alloc "
> @@ -470,9 +470,6 @@ megasas_alloc_cmds_fusion(struct megasas
> goto fail_cmd_list;
> }
>
> - memset(fusion->cmd_list, 0, sizeof(struct megasas_cmd_fusion *)
> - *max_cmd);
> -
> max_cmd = instance->max_fw_cmds;
> for (i = 0; i < max_cmd; i++) {
> fusion->cmd_list[i] = kmalloc(sizeof(struct megasas_cmd_fusion),

Acked-by: Adam Radford <[email protected]>