Hi,
On Thu, Feb 29, 2024 at 10:11 PM Cong Yang
<[email protected]> wrote:
>
> The current measured frame rate is 59.95Hz, which does not meet the
> requirements of touch-stylus and stylus cannot work normally. After
> adjustment, the actual measurement is 60.001Hz. Now this panel looks
> like it's only used by me on the MTK platform, so let's change this
> set of parameters.
>
> Fixes: cea7008190ad ("drm/panel: Fine tune Himax83102-j02 panel HFP and HBP")
Your "Fixes:" tag is not quite right. It needs to have the _exact_
subject of the old commit message, AKA:
Fixes: cea7008190ad ("drm/panel: boe-tv101wum-nl6: Fine tune
Himax83102-j02 panel HFP and HBP")
> Signed-off-by: Cong Yang <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
A little odd that the patch you're fixing claimed that it caused the
measured rate to be 60.01Hz and here you're saying that it ended up
being 59.95Hz. I guess there was a measurement error when the previous
patch was posted?
In any case, the argument still holds that this is a panel that still
appears to be only used by your board, so small tweaks to the numbers
here seem OK.
Landed to "drm-misc-fixes" after:
* Adding "(again)" to the end of the subject to make it distinct from
the previous patch description
* Fixing your Fixes tag
9dfc46c87cdc drm/panel: boe-tv101wum-nl6: Fine tune Himax83102-j02
panel HFP and HBP (again)
-Doug
Hi,
On Tue, Mar 5, 2024 at 12:51 AM Doug Anderson <[email protected]> wrote:
>
> Hi,
>
> On Thu, Feb 29, 2024 at 10:11 PM Cong Yang
> <[email protected]> wrote:
> >
> > The current measured frame rate is 59.95Hz, which does not meet the
> > requirements of touch-stylus and stylus cannot work normally. After
> > adjustment, the actual measurement is 60.001Hz. Now this panel looks
> > like it's only used by me on the MTK platform, so let's change this
> > set of parameters.
> >
> > Fixes: cea7008190ad ("drm/panel: Fine tune Himax83102-j02 panel HFP and HBP")
>
> Your "Fixes:" tag is not quite right. It needs to have the _exact_
> subject of the old commit message, AKA:
>
> Fixes: cea7008190ad ("drm/panel: boe-tv101wum-nl6: Fine tune
> Himax83102-j02 panel HFP and HBP")
Ack! Thanks, I’ll fix it now.
>
> > Signed-off-by: Cong Yang <[email protected]>
> > ---
> > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> A little odd that the patch you're fixing claimed that it caused the
> measured rate to be 60.01Hz and here you're saying that it ended up
> being 59.95Hz. I guess there was a measurement error when the previous
> patch was posted?
Yes, the previous patch measurement was wrong.
>
> In any case, the argument still holds that this is a panel that still
> appears to be only used by your board, so small tweaks to the numbers
> here seem OK.
>
> Landed to "drm-misc-fixes" after:
> * Adding "(again)" to the end of the subject to make it distinct from
> the previous patch description
> * Fixing your Fixes tag
>
> 9dfc46c87cdc drm/panel: boe-tv101wum-nl6: Fine tune Himax83102-j02
> panel HFP and HBP (again)
Got it. Thanks.
>
>
> -Doug