The informations come from the coccinelle tool.
drivers/devfreq/tegra-devfreq.c:577:5-8: Unneeded variable: "ret".
Return "0" on line 603
drivers/devfreq/rk3399_dmc.c:325:2-3: Unneeded semicolon
drivers/devfreq/event/rockchip-dfi.c:214:2-3: Unneeded semicolon
Yangtao Li (3):
PM / devfreq: rk3399_dmc: remove unneeded semicolon
PM / devfreq: rockchip-dfi: remove unneeded semicolon
PM / devfreq: tegra: remove unneeded variable
drivers/devfreq/event/rockchip-dfi.c | 2 +-
drivers/devfreq/rk3399_dmc.c | 2 +-
drivers/devfreq/tegra-devfreq.c | 7 ++-----
3 files changed, 4 insertions(+), 7 deletions(-)
--
2.17.0
The semicolon is unneeded, so remove it.
Signed-off-by: Yangtao Li <[email protected]>
---
drivers/devfreq/rk3399_dmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index e795ad2b3f6b..a228dad2bee4 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
dev_err(dev, "Cannot get the clk dmc_clk\n");
return PTR_ERR(data->dmc_clk);
- };
+ }
data->edev = devfreq_event_get_edev_by_phandle(dev, 0);
if (IS_ERR(data->edev))
--
2.17.0
The semicolon is unneeded, so remove it.
Signed-off-by: Yangtao Li <[email protected]>
---
drivers/devfreq/event/rockchip-dfi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
index 22b113363ffc..fcbf76ebf55d 100644
--- a/drivers/devfreq/event/rockchip-dfi.c
+++ b/drivers/devfreq/event/rockchip-dfi.c
@@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
if (IS_ERR(data->clk)) {
dev_err(dev, "Cannot get the clk dmc_clk\n");
return PTR_ERR(data->clk);
- };
+ }
/* try to find the optional reference to the pmu syscon */
node = of_parse_phandle(np, "rockchip,pmu", 0);
--
2.17.0
This variable is not used after initialization, so
remove it. And in order to unify the code style,
move the location where the dev_get_drvdata is called
by the way.
Signed-off-by: Yangtao Li <[email protected]>
---
drivers/devfreq/tegra-devfreq.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
index c59d2eee5d30..c89ba7b834ff 100644
--- a/drivers/devfreq/tegra-devfreq.c
+++ b/drivers/devfreq/tegra-devfreq.c
@@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
static int tegra_governor_event_handler(struct devfreq *devfreq,
unsigned int event, void *data)
{
- struct tegra_devfreq *tegra;
- int ret = 0;
-
- tegra = dev_get_drvdata(devfreq->dev.parent);
+ struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
switch (event) {
case DEVFREQ_GOV_START:
@@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
break;
}
- return ret;
+ return 0;
}
static struct devfreq_governor tegra_devfreq_governor = {
--
2.17.0
Hi,
On 19. 2. 17. 오전 12:18, Yangtao Li wrote:
> The semicolon is unneeded, so remove it.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/devfreq/rk3399_dmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index e795ad2b3f6b..a228dad2bee4 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
>
> dev_err(dev, "Cannot get the clk dmc_clk\n");
> return PTR_ERR(data->dmc_clk);
> - };
> + }
>
> data->edev = devfreq_event_get_edev_by_phandle(dev, 0);
> if (IS_ERR(data->edev))
>
Reviewed-by: Chanwoo Choi <[email protected]>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
On 19. 2. 17. 오전 12:18, Yangtao Li wrote:
> The semicolon is unneeded, so remove it.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/devfreq/event/rockchip-dfi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> index 22b113363ffc..fcbf76ebf55d 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
> if (IS_ERR(data->clk)) {
> dev_err(dev, "Cannot get the clk dmc_clk\n");
> return PTR_ERR(data->clk);
> - };
> + }
>
> /* try to find the optional reference to the pmu syscon */
> node = of_parse_phandle(np, "rockchip,pmu", 0);
>
Reviewed-by: Chanwoo Choi <[email protected]>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 19. 2. 17. 오전 12:18, Yangtao Li wrote:
> This variable is not used after initialization, so
> remove it. And in order to unify the code style,
> move the location where the dev_get_drvdata is called
> by the way.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> drivers/devfreq/tegra-devfreq.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
> index c59d2eee5d30..c89ba7b834ff 100644
> --- a/drivers/devfreq/tegra-devfreq.c
> +++ b/drivers/devfreq/tegra-devfreq.c
> @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
> static int tegra_governor_event_handler(struct devfreq *devfreq,
> unsigned int event, void *data)
> {
> - struct tegra_devfreq *tegra;
> - int ret = 0;
> -
> - tegra = dev_get_drvdata(devfreq->dev.parent);
> + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
>
> switch (event) {
> case DEVFREQ_GOV_START:
> @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
> break;
> }
>
> - return ret;
> + return 0;
> }
>
> static struct devfreq_governor tegra_devfreq_governor = {
>
Reviewed-by: Chanwoo Choi <[email protected]>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 18/02/2019 00:38, Chanwoo Choi wrote:
> On 19. 2. 17. 오전 12:18, Yangtao Li wrote:
>> This variable is not used after initialization, so
>> remove it. And in order to unify the code style,
>> move the location where the dev_get_drvdata is called
>> by the way.
>>
>> Signed-off-by: Yangtao Li <[email protected]>
>> ---
>> drivers/devfreq/tegra-devfreq.c | 7 ++-----
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
>> index c59d2eee5d30..c89ba7b834ff 100644
>> --- a/drivers/devfreq/tegra-devfreq.c
>> +++ b/drivers/devfreq/tegra-devfreq.c
>> @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
>> static int tegra_governor_event_handler(struct devfreq *devfreq,
>> unsigned int event, void *data)
>> {
>> - struct tegra_devfreq *tegra;
>> - int ret = 0;
>> -
>> - tegra = dev_get_drvdata(devfreq->dev.parent);
>> + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
>>
>> switch (event) {
>> case DEVFREQ_GOV_START:
>> @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
>> break;
>> }
>>
>> - return ret;
>> + return 0;
>> }
>>
>> static struct devfreq_governor tegra_devfreq_governor = {
>>
>
> Reviewed-by: Chanwoo Choi <[email protected]>
>
Acked-by: Jon Hunter <[email protected]>
Thanks!
Jon
--
nvpublic
On Mon, Feb 18, 2019 at 9:41 AM Chanwoo Choi <[email protected]> wrote:
>
> Hi,
>
> On 19. 2. 17. 오전 12:18, Yangtao Li wrote:
> > The semicolon is unneeded, so remove it.
> >
> > Signed-off-by: Yangtao Li <[email protected]>
> > ---
> > drivers/devfreq/event/rockchip-dfi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> > index 22b113363ffc..fcbf76ebf55d 100644
> > --- a/drivers/devfreq/event/rockchip-dfi.c
> > +++ b/drivers/devfreq/event/rockchip-dfi.c
> > @@ -211,7 +211,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
> > if (IS_ERR(data->clk)) {
> > dev_err(dev, "Cannot get the clk dmc_clk\n");
> > return PTR_ERR(data->clk);
> > - };
> > + }
> >
> > /* try to find the optional reference to the pmu syscon */
> > node = of_parse_phandle(np, "rockchip,pmu", 0);
> >
>
> Reviewed-by: Chanwoo Choi <[email protected]>
Acked-by: MyungJoo Ham <[email protected]>
Merged. Thanks.
>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics
--
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics
On Mon, Feb 18, 2019 at 6:58 PM Jon Hunter <[email protected]> wrote:
>
>
> On 18/02/2019 00:38, Chanwoo Choi wrote:
> > On 19. 2. 17. 오전 12:18, Yangtao Li wrote:
> >> This variable is not used after initialization, so
> >> remove it. And in order to unify the code style,
> >> move the location where the dev_get_drvdata is called
> >> by the way.
> >>
> >> Signed-off-by: Yangtao Li <[email protected]>
> >> ---
> >> drivers/devfreq/tegra-devfreq.c | 7 ++-----
> >> 1 file changed, 2 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
> >> index c59d2eee5d30..c89ba7b834ff 100644
> >> --- a/drivers/devfreq/tegra-devfreq.c
> >> +++ b/drivers/devfreq/tegra-devfreq.c
> >> @@ -573,10 +573,7 @@ static int tegra_governor_get_target(struct devfreq *devfreq,
> >> static int tegra_governor_event_handler(struct devfreq *devfreq,
> >> unsigned int event, void *data)
> >> {
> >> - struct tegra_devfreq *tegra;
> >> - int ret = 0;
> >> -
> >> - tegra = dev_get_drvdata(devfreq->dev.parent);
> >> + struct tegra_devfreq *tegra = dev_get_drvdata(devfreq->dev.parent);
> >>
> >> switch (event) {
> >> case DEVFREQ_GOV_START:
> >> @@ -600,7 +597,7 @@ static int tegra_governor_event_handler(struct devfreq *devfreq,
> >> break;
> >> }
> >>
> >> - return ret;
> >> + return 0;
> >> }
> >>
> >> static struct devfreq_governor tegra_devfreq_governor = {
> >>
> >
> > Reviewed-by: Chanwoo Choi <[email protected]>
> >
>
> Acked-by: Jon Hunter <[email protected]>
>
> Thanks!
> Jon
Acked-by: MyungJoo Ham <[email protected]>
Merged. Thanks!
>
> --
> nvpublic
--
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics
On Mon, Feb 18, 2019 at 10:09 AM Chanwoo Choi <[email protected]> wrote:
>
> Hi,
>
> On 19. 2. 17. 오전 12:18, Yangtao Li wrote:
> > The semicolon is unneeded, so remove it.
> >
> > Signed-off-by: Yangtao Li <[email protected]>
> > ---
> > drivers/devfreq/rk3399_dmc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> > index e795ad2b3f6b..a228dad2bee4 100644
> > --- a/drivers/devfreq/rk3399_dmc.c
> > +++ b/drivers/devfreq/rk3399_dmc.c
> > @@ -322,7 +322,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
> >
> > dev_err(dev, "Cannot get the clk dmc_clk\n");
> > return PTR_ERR(data->dmc_clk);
> > - };
> > + }
> >
> > data->edev = devfreq_event_get_edev_by_phandle(dev, 0);
> > if (IS_ERR(data->edev))
> >
>
> Reviewed-by: Chanwoo Choi <[email protected]>
Acked-by: MyungJoo Ham <[email protected]>
Merged.
>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics
--
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics