Statically allocated array of pointed to hwmon_channel_info can be made
const for safety.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
This depends on hwmon core patch:
https://lore.kernel.org/all/[email protected]/
Therefore I propose this should also go via hwmon tree.
Cc: Jean Delvare <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: [email protected]
---
drivers/media/i2c/video-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
index dddf9827b314..abd472dcd497 100644
--- a/drivers/media/i2c/video-i2c.c
+++ b/drivers/media/i2c/video-i2c.c
@@ -274,7 +274,7 @@ static const struct hwmon_channel_info amg88xx_temp = {
.config = amg88xx_temp_config,
};
-static const struct hwmon_channel_info *amg88xx_info[] = {
+static const struct hwmon_channel_info * const amg88xx_info[] = {
&amg88xx_temp,
NULL
};
--
2.34.1
Hi Krzysztof,
On Fri, Apr 07, 2023 at 05:00:15PM +0200, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> This depends on hwmon core patch:
> https://lore.kernel.org/all/[email protected]/
>
> Therefore I propose this should also go via hwmon tree.
Works for me. Please add:
Acked-by: Sakari Ailus <[email protected]>
Thanks!
--
Kind regards,
Sakari Ailus
On Fri, Apr 07, 2023 at 08:16:30PM +0300, Sakari Ailus wrote:
> Hi Krzysztof,
>
> On Fri, Apr 07, 2023 at 05:00:15PM +0200, Krzysztof Kozlowski wrote:
> > Statically allocated array of pointed to hwmon_channel_info can be made
> > const for safety.
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >
> > ---
> >
> > This depends on hwmon core patch:
> > https://lore.kernel.org/all/[email protected]/
> >
> > Therefore I propose this should also go via hwmon tree.
>
> Works for me. Please add:
>
But not for me. Krzysztof jumped the gun here a bit.
I do not feel comfortable applying patches for 10+ subsystem
branches through hwmon. This is asking for trouble.
I created a stable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const
which everyone may use to merge the pre-requisite patch, or wait until
after the next merge window.
Guenter
On 4/7/23 08:00, Krzysztof Kozlowski wrote:
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> This depends on hwmon core patch:
> https://lore.kernel.org/all/[email protected]/
>
> Therefore I propose this should also go via hwmon tree.
>
I am not going to apply patches for 10+ subsystems through the hwmon tree.
This can only result in chaos. The dependent patch is available at
git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const
or wait until after the next commit window to apply this patch.
Thanks,
Guenter
> Cc: Jean Delvare <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: [email protected]
> ---
> drivers/media/i2c/video-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
> index dddf9827b314..abd472dcd497 100644
> --- a/drivers/media/i2c/video-i2c.c
> +++ b/drivers/media/i2c/video-i2c.c
> @@ -274,7 +274,7 @@ static const struct hwmon_channel_info amg88xx_temp = {
> .config = amg88xx_temp_config,
> };
>
> -static const struct hwmon_channel_info *amg88xx_info[] = {
> +static const struct hwmon_channel_info * const amg88xx_info[] = {
> &amg88xx_temp,
> NULL
> };
On Fri, Apr 7, 2023 at 8:00 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Statically allocated array of pointed to hwmon_channel_info can be made
> const for safety.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Matt Ranostay <[email protected]>
>
> ---
>
> This depends on hwmon core patch:
> https://lore.kernel.org/all/[email protected]/
>
> Therefore I propose this should also go via hwmon tree.
>
> Cc: Jean Delvare <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: [email protected]
> ---
> drivers/media/i2c/video-i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c
> index dddf9827b314..abd472dcd497 100644
> --- a/drivers/media/i2c/video-i2c.c
> +++ b/drivers/media/i2c/video-i2c.c
> @@ -274,7 +274,7 @@ static const struct hwmon_channel_info amg88xx_temp = {
> .config = amg88xx_temp_config,
> };
>
> -static const struct hwmon_channel_info *amg88xx_info[] = {
> +static const struct hwmon_channel_info * const amg88xx_info[] = {
> &amg88xx_temp,
> NULL
> };
> --
> 2.34.1
>