2021-04-06 12:24:40

by Yang Li

Subject: [PATCH] csky: remove unused including <linux/version.h>

Fix the following versioncheck warnings:
./arch/csky/include/asm/io.h: 8 linux/version.h not needed.
./arch/csky/include/asm/uaccess.h: 14 linux/version.h not needed.
./arch/csky/kernel/process.c: 5 linux/version.h not needed.
./arch/csky/mm/dma-mapping.c: 12 linux/version.h not needed.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
arch/csky/include/asm/io.h | 1 -
arch/csky/include/asm/uaccess.h | 1 -
arch/csky/kernel/process.c | 1 -
arch/csky/mm/dma-mapping.c | 1 -
4 files changed, 4 deletions(-)

diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
index f826540..ed53f0b 100644
--- a/arch/csky/include/asm/io.h
+++ b/arch/csky/include/asm/io.h
@@ -5,7 +5,6 @@

#include <linux/pgtable.h>
#include <linux/types.h>
-#include <linux/version.h>

/*
* I/O memory access primitives. Reads are ordered relative to any
diff --git a/arch/csky/include/asm/uaccess.h b/arch/csky/include/asm/uaccess.h
index 3dec272..841e421 100644
--- a/arch/csky/include/asm/uaccess.h
+++ b/arch/csky/include/asm/uaccess.h
@@ -11,7 +11,6 @@
#include <linux/types.h>
#include <linux/sched.h>
#include <linux/string.h>
-#include <linux/version.h>
#include <asm/segment.h>

static inline int access_ok(const void *addr, unsigned long size)
diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
index 3d0ca22..5de0470 100644
--- a/arch/csky/kernel/process.c
+++ b/arch/csky/kernel/process.c
@@ -2,7 +2,6 @@
// Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd.

#include <linux/module.h>
-#include <linux/version.h>
#include <linux/sched.h>
#include <linux/sched/task_stack.h>
#include <linux/sched/debug.h>
diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
index c3a775a..8244702 100644
--- a/arch/csky/mm/dma-mapping.c
+++ b/arch/csky/mm/dma-mapping.c
@@ -9,7 +9,6 @@
#include <linux/mm.h>
#include <linux/scatterlist.h>
#include <linux/types.h>
-#include <linux/version.h>
#include <asm/cache.h>

static inline void cache_op(phys_addr_t paddr, size_t size,
--
1.8.3.1

2021-04-06 14:41:01

by Guo Ren

Subject: Re: [PATCH] csky: remove unused including <linux/version.h>

Acked by

On Tue, Apr 6, 2021 at 9:48 AM Yang Li <[email protected]> wrote:
>
> Fix the following versioncheck warnings:
> ./arch/csky/include/asm/io.h: 8 linux/version.h not needed.
> ./arch/csky/include/asm/uaccess.h: 14 linux/version.h not needed.
> ./arch/csky/kernel/process.c: 5 linux/version.h not needed.
> ./arch/csky/mm/dma-mapping.c: 12 linux/version.h not needed.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> arch/csky/include/asm/io.h | 1 -
> arch/csky/include/asm/uaccess.h | 1 -
> arch/csky/kernel/process.c | 1 -
> arch/csky/mm/dma-mapping.c | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/arch/csky/include/asm/io.h b/arch/csky/include/asm/io.h
> index f826540..ed53f0b 100644
> --- a/arch/csky/include/asm/io.h
> +++ b/arch/csky/include/asm/io.h
> @@ -5,7 +5,6 @@
>
> #include <linux/pgtable.h>
> #include <linux/types.h>
> -#include <linux/version.h>
>
> /*
> * I/O memory access primitives. Reads are ordered relative to any
> diff --git a/arch/csky/include/asm/uaccess.h b/arch/csky/include/asm/uaccess.h
> index 3dec272..841e421 100644
> --- a/arch/csky/include/asm/uaccess.h
> +++ b/arch/csky/include/asm/uaccess.h
> @@ -11,7 +11,6 @@
> #include <linux/types.h>
> #include <linux/sched.h>
> #include <linux/string.h>
> -#include <linux/version.h>
> #include <asm/segment.h>
>
> static inline int access_ok(const void *addr, unsigned long size)
> diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
> index 3d0ca22..5de0470 100644
> --- a/arch/csky/kernel/process.c
> +++ b/arch/csky/kernel/process.c
> @@ -2,7 +2,6 @@
> // Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd.
>
> #include <linux/module.h>
> -#include <linux/version.h>
> #include <linux/sched.h>
> #include <linux/sched/task_stack.h>
> #include <linux/sched/debug.h>
> diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
> index c3a775a..8244702 100644
> --- a/arch/csky/mm/dma-mapping.c
> +++ b/arch/csky/mm/dma-mapping.c
> @@ -9,7 +9,6 @@
> #include <linux/mm.h>
> #include <linux/scatterlist.h>
> #include <linux/types.h>
> -#include <linux/version.h>
> #include <asm/cache.h>
>
> static inline void cache_op(phys_addr_t paddr, size_t size,
> --
> 1.8.3.1
>


--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/