2019-04-30 09:30:01

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m

The THERMAL configuration option was changed from tristate to bool, but
a dependency on THERMAL=m was forgotten, leading to a warning when
running "make savedefconfig":

boolean symbol THERMAL tested for 'm'? test forced to 'n'

Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
index b6b3ff0fe17f5c4e..7ccb950aa7d4aa30 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
@@ -22,7 +22,6 @@ config MLXSW_CORE_HWMON
config MLXSW_CORE_THERMAL
bool "Thermal zone support for Mellanox Technologies Switch ASICs"
depends on MLXSW_CORE && THERMAL
- depends on !(MLXSW_CORE=y && THERMAL=m)
default y
---help---
Say Y here if you want to automatically control fans speed according
--
2.17.1


2019-04-30 09:40:16

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m

On 30/04/2019 11:28, Geert Uytterhoeven wrote:
> The THERMAL configuration option was changed from tristate to bool, but
> a dependency on THERMAL=m was forgotten, leading to a warning when
> running "make savedefconfig":
>
> boolean symbol THERMAL tested for 'm'? test forced to 'n'
>
> Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Thanks!

Acked-by: Daniel Lezcano <[email protected]>

> ---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
> index b6b3ff0fe17f5c4e..7ccb950aa7d4aa30 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
> +++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
> @@ -22,7 +22,6 @@ config MLXSW_CORE_HWMON
> config MLXSW_CORE_THERMAL
> bool "Thermal zone support for Mellanox Technologies Switch ASICs"
> depends on MLXSW_CORE && THERMAL
> - depends on !(MLXSW_CORE=y && THERMAL=m)
> default y
> ---help---
> Say Y here if you want to automatically control fans speed according
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2019-04-30 10:17:34

by Ido Schimmel

[permalink] [raw]
Subject: Re: [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m

On Tue, Apr 30, 2019 at 11:28:32AM +0200, Geert Uytterhoeven wrote:
> The THERMAL configuration option was changed from tristate to bool, but
> a dependency on THERMAL=m was forgotten, leading to a warning when
> running "make savedefconfig":
>
> boolean symbol THERMAL tested for 'm'? test forced to 'n'
>
> Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Ido Schimmel <[email protected]>

I assume this will be applied to the thermal tree?

2019-05-03 19:16:38

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH -next] mlxsw: Remove obsolete dependency on THERMAL=m

On Tue, 30 Apr 2019 at 11:29, Geert Uytterhoeven
<[email protected]> wrote:
>
> The THERMAL configuration option was changed from tristate to bool, but
> a dependency on THERMAL=m was forgotten, leading to a warning when
> running "make savedefconfig":
>
> boolean symbol THERMAL tested for 'm'? test forced to 'n'
>
> Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 -
> 1 file changed, 1 deletion(-)

This also fixes olddefconfig, image_name and other targets:
Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof