2018-10-16 14:59:43

by Lukasz Luba

Subject: [PATCH 08/11] DT: arm: exynos4: add support for thermal trip irq-mode

This patch adds support for new flash which indicates
that trip point triggers irq when temperature is met.
Exynos5433 supports 8 trip point which will trigger irq.
Above that number other trip points should be registered
without 'irq-mode' flag.
That will force the thermal framework to start polling
the temperature sensor under configured conditions and
handle the trip point.

Cc: Kukjin Kim <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Lukasz Luba <[email protected]>
---
arch/arm/boot/dts/exynos4-cpu-thermal.dtsi | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4-cpu-thermal.dtsi b/arch/arm/boot/dts/exynos4-cpu-thermal.dtsi
index 021d9fc..5e07289 100644
--- a/arch/arm/boot/dts/exynos4-cpu-thermal.dtsi
+++ b/arch/arm/boot/dts/exynos4-cpu-thermal.dtsi
@@ -17,22 +17,26 @@ thermal-zones {
cpu_alert0: cpu-alert-0 {
temperature = <70000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "active";
+ type = "passive";
+ irq-mode;
};
cpu_alert1: cpu-alert-1 {
temperature = <95000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "active";
+ type = "passive";
+ irq-mode;
};
cpu_alert2: cpu-alert-2 {
temperature = <110000>; /* millicelsius */
hysteresis = <10000>; /* millicelsius */
- type = "active";
+ type = "passive";
+ irq-mode;
};
cpu_crit0: cpu-crit-0 {
temperature = <120000>; /* millicelsius */
hysteresis = <0>; /* millicelsius */
type = "critical";
+ irq-mode;
};
};
cooling-maps {
--
2.7.4

2018-10-16 15:11:53

by Krzysztof Kozlowski

Subject: Re: [PATCH 08/11] DT: arm: exynos4: add support for thermal trip irq-mode

On Tue, 16 Oct 2018 at 16:56, Lukasz Luba <[email protected]> wrote:
>
> This patch adds support for new flash which indicates
> that trip point triggers irq when temperature is met.
> Exynos5433 supports 8 trip point which will trigger irq.

Exynos4? 4 trip points?

Beside that other comments apply as well.

Best regards,
Krzysztof