2022-05-31 10:31:12

by Hsin-Yi Wang

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: mt8183: Add panel rotation

krane, kakadu, and kodama boards have a default panel rotation.

Signed-off-by: Hsin-Yi Wang <[email protected]>
Reviewed-by: Enric Balletbo i Serra <[email protected]>
Tested-by: Enric Balletbo i Serra <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index 8d5bf73a9099..f0dd5a06629d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -276,6 +276,7 @@ panel: panel@0 {
avee-supply = <&ppvarp_lcd>;
pp1800-supply = <&pp1800_lcd>;
backlight = <&backlight_lcd0>;
+ rotation = <270>;
port {
panel_in: endpoint {
remote-endpoint = <&dsi_out>;
--
2.36.1.124.g0e6072fb45-goog



2022-06-06 15:52:03

by Hsin-Yi Wang

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: mt8183: Add panel rotation

On Mon, May 30, 2022 at 7:30 PM Hsin-Yi Wang <[email protected]> wrote:
>
> krane, kakadu, and kodama boards have a default panel rotation.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> Reviewed-by: Enric Balletbo i Serra <[email protected]>
> Tested-by: Enric Balletbo i Serra <[email protected]>
> ---

Hi Matthias,

The series ("Add a panel API to return panel orientation") might land
in drm-misc. With this series applied, we can add this patch to give
the correct default orientation for mt8183 kukui devices.
I didn't send this patch again with the series, since they might land
in different trees.

Thanks.

> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index 8d5bf73a9099..f0dd5a06629d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -276,6 +276,7 @@ panel: panel@0 {
> avee-supply = <&ppvarp_lcd>;
> pp1800-supply = <&pp1800_lcd>;
> backlight = <&backlight_lcd0>;
> + rotation = <270>;
> port {
> panel_in: endpoint {
> remote-endpoint = <&dsi_out>;
> --
> 2.36.1.124.g0e6072fb45-goog
>

2022-06-17 14:41:38

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: mt8183: Add panel rotation

Hi Hsin-Yi Wang,

On 06/06/2022 17:29, Hsin-Yi Wang wrote:
> On Mon, May 30, 2022 at 7:30 PM Hsin-Yi Wang <[email protected]> wrote:
>>
>> krane, kakadu, and kodama boards have a default panel rotation.
>>
>> Signed-off-by: Hsin-Yi Wang <[email protected]>
>> Reviewed-by: Enric Balletbo i Serra <[email protected]>
>> Tested-by: Enric Balletbo i Serra <[email protected]>
>> ---
>
> Hi Matthias,
>
> The series ("Add a panel API to return panel orientation") might land
> in drm-misc. With this series applied, we can add this patch to give
> the correct default orientation for mt8183 kukui devices.
> I didn't send this patch again with the series, since they might land
> in different trees.
>

I had a look on Linux next (next-20220617) and wasn't able to find the mtk_dsi.c
changes. What is the status of this?

Regards,
Matthias

> Thanks.
>
>> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> index 8d5bf73a9099..f0dd5a06629d 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> @@ -276,6 +276,7 @@ panel: panel@0 {
>> avee-supply = <&ppvarp_lcd>;
>> pp1800-supply = <&pp1800_lcd>;
>> backlight = <&backlight_lcd0>;
>> + rotation = <270>;
>> port {
>> panel_in: endpoint {
>> remote-endpoint = <&dsi_out>;
>> --
>> 2.36.1.124.g0e6072fb45-goog
>>

2022-06-17 14:41:38

by Hsin-Yi Wang

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: mt8183: Add panel rotation

On Fri, Jun 17, 2022 at 10:10 PM Matthias Brugger
<[email protected]> wrote:
>
> Hi Hsin-Yi Wang,
>
> On 06/06/2022 17:29, Hsin-Yi Wang wrote:
> > On Mon, May 30, 2022 at 7:30 PM Hsin-Yi Wang <[email protected]> wrote:
> >>
> >> krane, kakadu, and kodama boards have a default panel rotation.
> >>
> >> Signed-off-by: Hsin-Yi Wang <[email protected]>
> >> Reviewed-by: Enric Balletbo i Serra <[email protected]>
> >> Tested-by: Enric Balletbo i Serra <[email protected]>
> >> ---
> >
> > Hi Matthias,
> >
> > The series ("Add a panel API to return panel orientation") might land
> > in drm-misc. With this series applied, we can add this patch to give
> > the correct default orientation for mt8183 kukui devices.
> > I didn't send this patch again with the series, since they might land
> > in different trees.
> >
>
> I had a look on Linux next (next-20220617) and wasn't able to find the mtk_dsi.c
> changes. What is the status of this?
>
The mtk_dsi change got dropped. The latest is this series:
https://lore.kernel.org/lkml/[email protected]/,
still waiting to be picked or others' comments.

If the dts patch is picked without the drm series, there will be a
WARN, but won't affect boot or display up.


> Regards,
> Matthias
>
> > Thanks.
> >
> >> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> >> index 8d5bf73a9099..f0dd5a06629d 100644
> >> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> >> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> >> @@ -276,6 +276,7 @@ panel: panel@0 {
> >> avee-supply = <&ppvarp_lcd>;
> >> pp1800-supply = <&pp1800_lcd>;
> >> backlight = <&backlight_lcd0>;
> >> + rotation = <270>;
> >> port {
> >> panel_in: endpoint {
> >> remote-endpoint = <&dsi_out>;
> >> --
> >> 2.36.1.124.g0e6072fb45-goog
> >>

2022-07-07 15:36:48

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: mt8183: Add panel rotation



On 17/06/2022 16:25, Hsin-Yi Wang wrote:
> On Fri, Jun 17, 2022 at 10:10 PM Matthias Brugger
> <[email protected]> wrote:
>>
>> Hi Hsin-Yi Wang,
>>
>> On 06/06/2022 17:29, Hsin-Yi Wang wrote:
>>> On Mon, May 30, 2022 at 7:30 PM Hsin-Yi Wang <[email protected]> wrote:
>>>>
>>>> krane, kakadu, and kodama boards have a default panel rotation.
>>>>
>>>> Signed-off-by: Hsin-Yi Wang <[email protected]>
>>>> Reviewed-by: Enric Balletbo i Serra <[email protected]>
>>>> Tested-by: Enric Balletbo i Serra <[email protected]>
>>>> ---
>>>
>>> Hi Matthias,
>>>
>>> The series ("Add a panel API to return panel orientation") might land
>>> in drm-misc. With this series applied, we can add this patch to give
>>> the correct default orientation for mt8183 kukui devices.
>>> I didn't send this patch again with the series, since they might land
>>> in different trees.
>>>
>>
>> I had a look on Linux next (next-20220617) and wasn't able to find the mtk_dsi.c
>> changes. What is the status of this?
>>
> The mtk_dsi change got dropped. The latest is this series:
> https://lore.kernel.org/lkml/[email protected]/,
> still waiting to be picked or others' comments.
>

I saw this got merged, so merging this patch now.

Thanks!

> If the dts patch is picked without the drm series, there will be a
> WARN, but won't affect boot or display up.
>
>
>> Regards,
>> Matthias
>>
>>> Thanks.
>>>
>>>> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>>> index 8d5bf73a9099..f0dd5a06629d 100644
>>>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>>> @@ -276,6 +276,7 @@ panel: panel@0 {
>>>> avee-supply = <&ppvarp_lcd>;
>>>> pp1800-supply = <&pp1800_lcd>;
>>>> backlight = <&backlight_lcd0>;
>>>> + rotation = <270>;
>>>> port {
>>>> panel_in: endpoint {
>>>> remote-endpoint = <&dsi_out>;
>>>> --
>>>> 2.36.1.124.g0e6072fb45-goog
>>>>