2021-06-22 03:10:28

by Hsin-Yi Wang

[permalink] [raw]
Subject: [PATCH v3 RESEND 1/2] arm64: dts: mt8183: add mediatek,gce-events in mutex

mediatek,gce-events is read by mutex node.

Signed-off-by: Hsin-Yi Wang <[email protected]>
Reviewed-by: Enric Balletbo i Serra <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index c5e822b6b77a3..cf22d71161e58 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
reg = <0 0x14016000 0 0x1000>;
interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
+ mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
+ <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
};

larb0: larb@14017000 {
--
2.32.0.288.g62a8d224e6-goog


2021-06-22 03:11:04

by Hsin-Yi Wang

[permalink] [raw]
Subject: [PATCH v3 RESEND 2/2] dt-bindings: mediatek: Add optional mediatek,gce-events property

This property is used by gce clients.

Signed-off-by: Hsin-Yi Wang <[email protected]>
Acked-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/mailbox/mtk-gce.txt | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
index 7771ecaac5868..2ef7ff67cb2b0 100644
--- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
+++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
@@ -35,6 +35,10 @@ Optional properties for a client device:
start_offset: the start offset of register address that GCE can access.
size: the total size of register address that GCE can access.

+Optional properties for a client mutex node:
+- mediatek,gce-events: GCE events used by clients. The event numbers are
+ defined in 'dt-bindings/gce/<chip>-gce.h'.
+
Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h',
'dt-binding/gce/mt8183-gce.h' or 'dt-bindings/gce/mt6779-gce.h'. Such as
sub-system ids, thread priority, event ids.
@@ -62,3 +66,14 @@ Example for a client device:
<&gce SUBSYS_1401XXXX 0x2000 0x100>;
...
};
+
+Example for a client mutex node:
+ mutex: mutex@14020000 {
+ compatible = "mediatek,mt8173-disp-mutex";
+ reg = <0 0x14020000 0 0x1000>;
+ interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_LOW>;
+ power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
+ clocks = <&mmsys CLK_MM_MUTEX_32K>;
+ mediatek,gce-events = <CMDQ_EVENT_MUTEX0_STREAM_EOF>,
+ <CMDQ_EVENT_MUTEX1_STREAM_EOF>;
+ };
--
2.32.0.288.g62a8d224e6-goog

2021-07-26 10:29:53

by Hsin-Yi Wang

[permalink] [raw]
Subject: Re: [PATCH v3 RESEND 1/2] arm64: dts: mt8183: add mediatek,gce-events in mutex

On Tue, Jun 22, 2021 at 11:07 AM Hsin-Yi Wang <[email protected]> wrote:
>
> mediatek,gce-events is read by mutex node.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> Reviewed-by: Enric Balletbo i Serra <[email protected]>

Gentle ping on this series. thanks

> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a3..cf22d71161e58 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
> reg = <0 0x14016000 0 0x1000>;
> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
> power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> + mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
> + <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
> };
>
> larb0: larb@14017000 {
> --
> 2.32.0.288.g62a8d224e6-goog
>

2021-08-04 17:19:35

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH v3 RESEND 1/2] arm64: dts: mt8183: add mediatek,gce-events in mutex



On 26/07/2021 12:27, Hsin-Yi Wang wrote:
> On Tue, Jun 22, 2021 at 11:07 AM Hsin-Yi Wang <[email protected]> wrote:
>>
>> mediatek,gce-events is read by mutex node.
>>
>> Signed-off-by: Hsin-Yi Wang <[email protected]>
>> Reviewed-by: Enric Balletbo i Serra <[email protected]>
>
> Gentle ping on this series. thanks
>

Both are pushed to v5.14-next/dts64 now. Sorry for the delay.

Matthias

>> ---
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index c5e822b6b77a3..cf22d71161e58 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
>> reg = <0 0x14016000 0 0x1000>;
>> interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
>> power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
>> + mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
>> + <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
>> };
>>
>> larb0: larb@14017000 {
>> --
>> 2.32.0.288.g62a8d224e6-goog
>>