2023-12-26 12:21:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: sophgo: add MFD subsys support for Sophgo CV1800 series SoC

On 26/12/2023 11:04, Jingbao Qiu wrote:
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/sophgo,cv1800.h>
> +
> + syscon@5025000 {

This example and DTS suggest this is system-controller, so use that
name. Assuming this is system-controller, because I am still not sure.

Best regards,
Krzysztof



2023-12-27 07:37:27

by Jingbao Qiu

[permalink] [raw]
Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: sophgo: add MFD subsys support for Sophgo CV1800 series SoC

On Tue, Dec 26, 2023 at 8:21 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 26/12/2023 11:04, Jingbao Qiu wrote:
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/clock/sophgo,cv1800.h>
> > +
> > + syscon@5025000 {
>
> This example and DTS suggest this is system-controller, so use that
> name. Assuming this is system-controller, because I am still not sure.
>

Thanks,I will carefully consider how to name him.

> Best regards,
> Krzysztof
>