Add devicetree binding to describe the Power-On-Reset/POR for Sophgo CV1800 SoC.
Signed-off-by: Jingbao Qiu <[email protected]>
---
.../bindings/power/sophgo,cv1800-por.yaml | 29 +++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
diff --git a/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
new file mode 100644
index 000000000000..8706230a1cbc
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
@@ -0,0 +1,29 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/power/sophgo,cv1800-por.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Power-On-Reset/POR of the Sophgo CV1800 SoC
+
+maintainers:
+ - Jingbao Qiu <[email protected]>
+
+description:
+ This hardware provides triggering and timing control
+ for chip power on, off, and reset.
+
+properties:
+ compatible:
+ const: sophgo,cv1800-por
+
+required:
+ - compatible
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ por {
+ compatible = "sophgo,cv1800-por";
+ };
--
2.25.1
On 29/12/2023 10:06, Jingbao Qiu wrote:
> Add devicetree binding to describe the Power-On-Reset/POR for Sophgo CV1800 SoC.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Subject: Make it concise. It's way over the limit. Also, unnecessary
full stop.
This all applies to all your patches.
>
> Signed-off-by: Jingbao Qiu <[email protected]>
> ---
What changed here? Where is the changelog? Did you just ignore entire
feedback from v3?
> .../bindings/power/sophgo,cv1800-por.yaml | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> new file mode 100644
> index 000000000000..8706230a1cbc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/sophgo,cv1800-por.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Power-On-Reset/POR of the Sophgo CV1800 SoC
> +
> +maintainers:
> + - Jingbao Qiu <[email protected]>
> +
> +description:
> + This hardware provides triggering and timing control
> + for chip power on, off, and reset.
> +
> +properties:
> + compatible:
> + const: sophgo,cv1800-por
> +
Empty schema, drop entire file. You do not need it.
Best regards,
Krzysztof
On Thu, Jan 4, 2024 at 4:37 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 29/12/2023 10:06, Jingbao Qiu wrote:
> > Add devicetree binding to describe the Power-On-Reset/POR for Sophgo CV1800 SoC.
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit):
> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Subject: Make it concise. It's way over the limit. Also, unnecessary
> full stop.
>
> This all applies to all your patches.
>
I will do that.
> >
>
> > Signed-off-by: Jingbao Qiu <[email protected]>
> > ---
>
> What changed here? Where is the changelog? Did you just ignore entire
> feedback from v3?
Actually, I separated the previous patches because there were issues
in various places.
I want to solve it bit by bit. Should I continue with the current
patch changes or return to
the previous patch?
>
> > .../bindings/power/sophgo,cv1800-por.yaml | 29 +++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> > new file mode 100644
> > index 000000000000..8706230a1cbc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/sophgo,cv1800-por.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Power-On-Reset/POR of the Sophgo CV1800 SoC
> > +
> > +maintainers:
> > + - Jingbao Qiu <[email protected]>
> > +
> > +description:
> > + This hardware provides triggering and timing control
> > + for chip power on, off, and reset.
> > +
> > +properties:
> > + compatible:
> > + const: sophgo,cv1800-por
> > +
>
> Empty schema, drop entire file. You do not need it.
>
I will drop it.
Best regards,
Jingbao Qiu
> Best regards,
> Krzysztof
>
On 04/01/2024 11:39, Jingbao Qiu wrote:
> On Thu, Jan 4, 2024 at 4:37 PM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> On 29/12/2023 10:06, Jingbao Qiu wrote:
>>> Add devicetree binding to describe the Power-On-Reset/POR for Sophgo CV1800 SoC.
>>
>> Please wrap commit message according to Linux coding style / submission
>> process (neither too early nor over the limit):
>> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>>
>> Subject: Make it concise. It's way over the limit. Also, unnecessary
>> full stop.
>>
>> This all applies to all your patches.
>>
>
> I will do that.
>
>>>
>>
>>> Signed-off-by: Jingbao Qiu <[email protected]>
>>> ---
>>
>> What changed here? Where is the changelog? Did you just ignore entire
>> feedback from v3?
>
> Actually, I separated the previous patches because there were issues
> in various places.
> I want to solve it bit by bit. Should I continue with the current
> patch changes or return to
> the previous patch?
You need to keep consistent versioning and changelogs.
Best regards,
Krzysztof