2018-08-17 23:51:05

by Moritz Fischer

Subject: [PATCH] fpga: dfl: region: Restory symmetry in probe()/remove()

Replace dev_get_drvdata() with platform_get_drvdata() to
match the platform_set_drvdata() in the probe function of
the platform driver.

Fixes commit bb61b9be3e6b ("fpga: dfl: add fpga region platform driver for
FME")
Signed-off-by: Moritz Fischer <[email protected]>
---
drivers/fpga/dfl-fme-region.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
index 0b7e19c27c6d..ce7ebe4b3212 100644
--- a/drivers/fpga/dfl-fme-region.c
+++ b/drivers/fpga/dfl-fme-region.c
@@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev)

static int fme_region_remove(struct platform_device *pdev)
{
- struct fpga_region *region = dev_get_drvdata(&pdev->dev);
+ struct fpga_region *region = platform_get_drvdata(&pdev->dev);

fpga_region_unregister(region);
fpga_mgr_put(region->mgr);
--
2.18.0

2018-08-18 00:45:59

by Moritz Fischer

Subject: Re: [PATCH] fpga: dfl: region: Restory symmetry in probe()/remove()

On Fri, Aug 17, 2018 at 4:40 PM, Moritz Fischer <[email protected]> wrote:
> Replace dev_get_drvdata() with platform_get_drvdata() to
> match the platform_set_drvdata() in the probe function of
> the platform driver.
>
> Fixes commit bb61b9be3e6b ("fpga: dfl: add fpga region platform driver for
> FME")
> Signed-off-by: Moritz Fischer <[email protected]>
> ---
> drivers/fpga/dfl-fme-region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
> index 0b7e19c27c6d..ce7ebe4b3212 100644
> --- a/drivers/fpga/dfl-fme-region.c
> +++ b/drivers/fpga/dfl-fme-region.c
> @@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev)
>
> static int fme_region_remove(struct platform_device *pdev)
> {
> - struct fpga_region *region = dev_get_drvdata(&pdev->dev);
> + struct fpga_region *region = platform_get_drvdata(&pdev->dev);
Blergh ... that doesn't even compile. I'll resubmit next week. Sorry
for the noise.
Should of course be platform_get_drvdata(pdev);

- Moritz