2023-08-31 18:47:30

by Su Hui

Subject: [PATCH 2/2] ACPI: OSL: add __printf format attribute to acpi_os_vprintf

With gcc and W=1 option to compile kernel, warning happends:

drivers/acpi/osl.c:156:2: error:
function ‘acpi_os_vprintf’ might be a candidate for ‘gnu_printf’
format attribute [-Werror=suggest-attribute=format].

Allow the compiler to recognize and check format strings is safer.

Signed-off-by: Su Hui <[email protected]>
---
drivers/acpi/osl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index f725813d0cce..357f1325485d 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -149,7 +149,7 @@ void acpi_os_printf(const char *fmt, ...)
}
EXPORT_SYMBOL(acpi_os_printf);

-void acpi_os_vprintf(const char *fmt, va_list args)
+void __printf(1, 0) acpi_os_vprintf(const char *fmt, va_list args)
{
static char buffer[512];

--
2.30.2

2023-09-21 19:10:08

by Rafael J. Wysocki

Subject: Re: [PATCH 2/2] ACPI: OSL: add __printf format attribute to acpi_os_vprintf

On Thu, Aug 31, 2023 at 9:35 AM Su Hui <[email protected]> wrote:
>
> With gcc and W=1 option to compile kernel, warning happends:
>
> drivers/acpi/osl.c:156:2: error:
> function ‘acpi_os_vprintf’ might be a candidate for ‘gnu_printf’
> format attribute [-Werror=suggest-attribute=format].
>
> Allow the compiler to recognize and check format strings is safer.
>
> Signed-off-by: Su Hui <[email protected]>
> ---
> drivers/acpi/osl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index f725813d0cce..357f1325485d 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -149,7 +149,7 @@ void acpi_os_printf(const char *fmt, ...)
> }
> EXPORT_SYMBOL(acpi_os_printf);
>
> -void acpi_os_vprintf(const char *fmt, va_list args)
> +void __printf(1, 0) acpi_os_vprintf(const char *fmt, va_list args)
> {
> static char buffer[512];
>
> --

Applied (with some subject and changelog edits) as 6.7 material, thanks!