2020-01-20 13:35:14

by Benjamin GAIGNARD

Subject: [PATCH] cpuidle: sysfs: fix warning when compiling with W=1

Fix kernel documentation comments to remove the warnings when
compiling with W=1.

Signed-off-by: Benjamin Gaignard <[email protected]>
---
drivers/cpuidle/sysfs.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
index 38ef770be90d..1909584e1e50 100644
--- a/drivers/cpuidle/sysfs.c
+++ b/drivers/cpuidle/sysfs.c
@@ -142,6 +142,7 @@ static struct attribute_group cpuidle_attr_group = {

/**
* cpuidle_add_interface - add CPU global sysfs attributes
+ * @dev: the target device
*/
int cpuidle_add_interface(struct device *dev)
{
@@ -153,6 +154,7 @@ int cpuidle_add_interface(struct device *dev)

/**
* cpuidle_remove_interface - remove CPU global sysfs attributes
+ * @dev: the target device
*/
void cpuidle_remove_interface(struct device *dev)
{
@@ -615,7 +617,7 @@ static struct kobj_type ktype_driver_cpuidle = {

/**
* cpuidle_add_driver_sysfs - adds the driver name sysfs attribute
- * @device: the target device
+ * @dev: the target device
*/
static int cpuidle_add_driver_sysfs(struct cpuidle_device *dev)
{
@@ -646,7 +648,7 @@ static int cpuidle_add_driver_sysfs(struct cpuidle_device *dev)

/**
* cpuidle_remove_driver_sysfs - removes the driver name sysfs attribute
- * @device: the target device
+ * @dev: the target device
*/
static void cpuidle_remove_driver_sysfs(struct cpuidle_device *dev)
{
--
2.15.0

2020-01-22 23:44:28

by Rafael J. Wysocki

Subject: Re: [PATCH] cpuidle: sysfs: fix warning when compiling with W=1

On Mon, Jan 20, 2020 at 2:34 PM Benjamin Gaignard
<[email protected]> wrote:
>
> Fix kernel documentation comments to remove the warnings when
> compiling with W=1.
>
> Signed-off-by: Benjamin Gaignard <[email protected]>
> ---
> drivers/cpuidle/sysfs.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c
> index 38ef770be90d..1909584e1e50 100644
> --- a/drivers/cpuidle/sysfs.c
> +++ b/drivers/cpuidle/sysfs.c
> @@ -142,6 +142,7 @@ static struct attribute_group cpuidle_attr_group = {
>
> /**
> * cpuidle_add_interface - add CPU global sysfs attributes
> + * @dev: the target device
> */
> int cpuidle_add_interface(struct device *dev)
> {
> @@ -153,6 +154,7 @@ int cpuidle_add_interface(struct device *dev)
>
> /**
> * cpuidle_remove_interface - remove CPU global sysfs attributes
> + * @dev: the target device
> */
> void cpuidle_remove_interface(struct device *dev)
> {
> @@ -615,7 +617,7 @@ static struct kobj_type ktype_driver_cpuidle = {
>
> /**
> * cpuidle_add_driver_sysfs - adds the driver name sysfs attribute
> - * @device: the target device
> + * @dev: the target device
> */
> static int cpuidle_add_driver_sysfs(struct cpuidle_device *dev)
> {
> @@ -646,7 +648,7 @@ static int cpuidle_add_driver_sysfs(struct cpuidle_device *dev)
>
> /**
> * cpuidle_remove_driver_sysfs - removes the driver name sysfs attribute
> - * @device: the target device
> + * @dev: the target device
> */
> static void cpuidle_remove_driver_sysfs(struct cpuidle_device *dev)
> {
> --

Queued up as 5.6 material, thanks!