2021-03-25 07:51:51

by Xiongfeng Wang

Subject: [PATCH 1/4] PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name in the header

Fixes the following W=1 kernel build warning(s):

drivers/pci/hotplug/acpi_pcihp.c:167: warning: expecting prototype for acpi_pcihp_check_ejectable(). Prototype was for acpi_pci_check_ejectable() instead

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Xiongfeng Wang <[email protected]>
---
drivers/pci/hotplug/acpi_pcihp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c
index 2750a64cecd3..4fedebf2f8c1 100644
--- a/drivers/pci/hotplug/acpi_pcihp.c
+++ b/drivers/pci/hotplug/acpi_pcihp.c
@@ -157,7 +157,7 @@ static int pcihp_is_ejectable(acpi_handle handle)
}

/**
- * acpi_pcihp_check_ejectable - check if handle is ejectable ACPI PCI slot
+ * acpi_pci_check_ejectable - check if handle is ejectable ACPI PCI slot
* @pbus: the PCI bus of the PCI slot corresponding to 'handle'
* @handle: ACPI handle to check
*
--
2.20.1

2021-03-25 17:33:45

by Rafael J. Wysocki

Subject: Re: [PATCH 1/4] PCI: acpi_pcihp: Correct acpi_pci_check_ejectable() function name in the header

On Thu, Mar 25, 2021 at 8:50 AM Xiongfeng Wang
<[email protected]> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/pci/hotplug/acpi_pcihp.c:167: warning: expecting prototype for acpi_pcihp_check_ejectable(). Prototype was for acpi_pci_check_ejectable() instead
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Xiongfeng Wang <[email protected]>
> ---
> drivers/pci/hotplug/acpi_pcihp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/acpi_pcihp.c b/drivers/pci/hotplug/acpi_pcihp.c
> index 2750a64cecd3..4fedebf2f8c1 100644
> --- a/drivers/pci/hotplug/acpi_pcihp.c
> +++ b/drivers/pci/hotplug/acpi_pcihp.c
> @@ -157,7 +157,7 @@ static int pcihp_is_ejectable(acpi_handle handle)
> }
>
> /**
> - * acpi_pcihp_check_ejectable - check if handle is ejectable ACPI PCI slot
> + * acpi_pci_check_ejectable - check if handle is ejectable ACPI PCI slot

Again, this is about fixing a kerneldoc comment, so please change the
subject to reflect that more precisely.

This applies to all of the patches in the series AFAICS.

> * @pbus: the PCI bus of the PCI slot corresponding to 'handle'
> * @handle: ACPI handle to check
> *
> --
> 2.20.1
>