From: Rafael J. Wysocki <[email protected]>
To avoid situations in which the actual states of certain ACPI power
resources are not known just because they have never been referenced
by any device configuration objects, check the initial states of all
power resources as soon as they are found in the ACPI namespace (and
fall back to turning them on if the state check fails).
Signed-off-by: Rafael J. Wysocki <[email protected]>
---
Andreas, please test this patch (on top of the [1/2]) and let me know
if it works for you.
Thanks!
---
drivers/acpi/power.c | 30 +++++++++++++-----------------
1 file changed, 13 insertions(+), 17 deletions(-)
Index: linux-pm/drivers/acpi/power.c
===================================================================
--- linux-pm.orig/drivers/acpi/power.c
+++ linux-pm/drivers/acpi/power.c
@@ -923,6 +919,7 @@ struct acpi_device *acpi_add_power_resou
union acpi_object acpi_object;
struct acpi_buffer buffer = { sizeof(acpi_object), &acpi_object };
acpi_status status;
+ u8 state_dummy;
int result;
acpi_bus_get_device(handle, &device);
@@ -951,6 +948,10 @@ struct acpi_device *acpi_add_power_resou
resource->order = acpi_object.power_resource.resource_order;
resource->state = ACPI_POWER_RESOURCE_STATE_UNKNOWN;
+ /* Get the initial state or just flip it on if that fails. */
+ if (acpi_power_get_state(resource, &state_dummy))
+ __acpi_power_on(resource);
+
pr_info("%s [%s]\n", acpi_device_name(device), acpi_device_bid(device));
device->flags.match_driver = true;
Am Freitag, 15. Oktober 2021, 19:14:10 CEST schrieb Rafael J. Wysocki:
> From: Rafael J. Wysocki <[email protected]>
>
> To avoid situations in which the actual states of certain ACPI power
> resources are not known just because they have never been referenced
> by any device configuration objects, check the initial states of all
> power resources as soon as they are found in the ACPI namespace (and
> fall back to turning them on if the state check fails).
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---
>
> Andreas, please test this patch (on top of the [1/2]) and let me know
> if it works for you.
>
I see no negative impact (actually, no impact at all) of the second
additional patch. The network card is again working fine now.
Boot logs (unpatched, with one patch, with both patches) at
https://dev.gentoo.org/~dilfridge/igb/ (the 5.14.12* files).
Best,
Andreas
--
PD Dr. Andreas K. Huettel
Institute for Experimental and Applied Physics
University of Regensburg
93040 Regensburg
Germany
tel. +49 151 241 67748 (mobile)
tel. +49 941 943 1618 (office)
e-mail [email protected]
http://www.akhuettel.de/
http://www.physik.uni-r.de/forschung/huettel/
On Mon, Oct 18, 2021 at 12:41 PM Andreas K. Huettel
<[email protected]> wrote:
>
> Am Freitag, 15. Oktober 2021, 19:14:10 CEST schrieb Rafael J. Wysocki:
> > From: Rafael J. Wysocki <[email protected]>
> >
> > To avoid situations in which the actual states of certain ACPI power
> > resources are not known just because they have never been referenced
> > by any device configuration objects, check the initial states of all
> > power resources as soon as they are found in the ACPI namespace (and
> > fall back to turning them on if the state check fails).
> >
> > Signed-off-by: Rafael J. Wysocki <[email protected]>
> > ---
> >
> > Andreas, please test this patch (on top of the [1/2]) and let me know
> > if it works for you.
> >
>
> I see no negative impact (actually, no impact at all) of the second
> additional patch. The network card is again working fine now.
>
> Boot logs (unpatched, with one patch, with both patches) at
> https://dev.gentoo.org/~dilfridge/igb/ (the 5.14.12* files).
Thanks!