Active mode for amd-pstate has shown enough success now that it makes sense
to enable it by default on client systems.
This series introduces a new kernel configuration option to set the default
policy for amd-pstate modes for a kernel.
Server systems will by identified by the PM preferred profile and still be
set as disabled by default for now.
v2->v3:
* Drop patch 4; Intel intentionally doesn't want intel-pstate on SOHO
server
* Move symbols from patch 1 into patch 2
* Add tags
Mario Limonciello (3):
ACPI: CPPC: Add definition for undefined FADT preferred PM profile
value
cpufreq: amd-pstate: Set a fallback policy based on preferred_profile
cpufreq: amd-pstate: Add a kernel config option to set default mode
drivers/cpufreq/Kconfig.x86 | 17 ++++++
drivers/cpufreq/amd-pstate.c | 101 +++++++++++++++++++++++++----------
include/acpi/actbl.h | 3 +-
include/linux/amd-pstate.h | 4 +-
4 files changed, 96 insertions(+), 29 deletions(-)
--
2.34.1
In the event a new preferred PM profile value is introduced it's best for
code to be able to defensively guard against it so that the wrong settings
don't get applied on a new system that uses this profile but ancient
kernels.
Acked-by: Huang Rui <[email protected]>
Suggested-by: Gautham Ranjal Shenoy <[email protected]>
Link: https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#fixed-acpi-description-table-fadt
Signed-off-by: Mario Limonciello <[email protected]>
---
v2->v3:
* Drop new symbols (they fold into patch 2)
* Update commit message
* Add Ray's tag
---
include/acpi/actbl.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/acpi/actbl.h b/include/acpi/actbl.h
index e5dfb6f4de52..451f6276da49 100644
--- a/include/acpi/actbl.h
+++ b/include/acpi/actbl.h
@@ -307,7 +307,8 @@ enum acpi_preferred_pm_profiles {
PM_SOHO_SERVER = 5,
PM_APPLIANCE_PC = 6,
PM_PERFORMANCE_SERVER = 7,
- PM_TABLET = 8
+ PM_TABLET = 8,
+ NR_PM_PROFILES = 9
};
/* Values for sleep_status and sleep_control registers (V5+ FADT) */
--
2.34.1
[AMD Official Use Only - General]
> -----Original Message-----
> From: Limonciello, Mario <[email protected]>
> Sent: Wednesday, June 21, 2023 1:25 AM
> To: Rafael J . Wysocki <[email protected]>
> Cc: Len Brown <[email protected]>; Huang, Ray <[email protected]>;
> [email protected]; [email protected]; linux-
> [email protected]; Shenoy, Gautham Ranjal
> <[email protected]>; Karny, Wyes <[email protected]>;
> Yuan, Perry <[email protected]>; Limonciello, Mario
> <[email protected]>
> Subject: [PATCH v3 1/3] ACPI: CPPC: Add definition for undefined FADT
> preferred PM profile value
>
> In the event a new preferred PM profile value is introduced it's best for code
> to be able to defensively guard against it so that the wrong settings don't get
> applied on a new system that uses this profile but ancient kernels.
>
> Acked-by: Huang Rui <[email protected]>
> Suggested-by: Gautham Ranjal Shenoy <[email protected]>
> Link:
> https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/05_ACPI_Software_Progr
> amming_Model/ACPI_Software_Programming_Model.html#fixed-acpi-
> description-table-fadt
> Signed-off-by: Mario Limonciello <[email protected]>
> ---
> v2->v3:
> * Drop new symbols (they fold into patch 2)
> * Update commit message
> * Add Ray's tag
> ---
> include/acpi/actbl.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/acpi/actbl.h b/include/acpi/actbl.h index
> e5dfb6f4de52..451f6276da49 100644
> --- a/include/acpi/actbl.h
> +++ b/include/acpi/actbl.h
> @@ -307,7 +307,8 @@ enum acpi_preferred_pm_profiles {
> PM_SOHO_SERVER = 5,
> PM_APPLIANCE_PC = 6,
> PM_PERFORMANCE_SERVER = 7,
> - PM_TABLET = 8
> + PM_TABLET = 8,
> + NR_PM_PROFILES = 9
> };
>
> /* Values for sleep_status and sleep_control registers (V5+ FADT) */
> --
> 2.34.1
LGTM,
Reviewed-by: Perry Yuan <[email protected]>
On Tue, Jun 20, 2023 at 7:27 PM Mario Limonciello
<[email protected]> wrote:
>
> Active mode for amd-pstate has shown enough success now that it makes sense
> to enable it by default on client systems.
>
> This series introduces a new kernel configuration option to set the default
> policy for amd-pstate modes for a kernel.
>
> Server systems will by identified by the PM preferred profile and still be
> set as disabled by default for now.
>
> v2->v3:
> * Drop patch 4; Intel intentionally doesn't want intel-pstate on SOHO
> server
> * Move symbols from patch 1 into patch 2
> * Add tags
> Mario Limonciello (3):
> ACPI: CPPC: Add definition for undefined FADT preferred PM profile
> value
> cpufreq: amd-pstate: Set a fallback policy based on preferred_profile
> cpufreq: amd-pstate: Add a kernel config option to set default mode
>
> drivers/cpufreq/Kconfig.x86 | 17 ++++++
> drivers/cpufreq/amd-pstate.c | 101 +++++++++++++++++++++++++----------
> include/acpi/actbl.h | 3 +-
> include/linux/amd-pstate.h | 4 +-
> 4 files changed, 96 insertions(+), 29 deletions(-)
>
> --
All applied as 6.5 material, thanks!