2019-08-31 08:35:04

by tiantao (H)

Subject: [PATCH] ACPICA: Namespace: fix the no brace needed warning

for if else statements having single block no braces are needed fixed
the following checkpatch warning

WARNING: braces {} are not necessary for any arm of this statement
+ if (!prev_node) {
[...]
+ } else {
[...]

Signed-off-by: tiantao <[email protected]>
---
drivers/acpi/acpica/nsaccess.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/acpica/nsaccess.c b/drivers/acpi/acpica/nsaccess.c
index 2566e2d..7cef22a 100644
--- a/drivers/acpi/acpica/nsaccess.c
+++ b/drivers/acpi/acpica/nsaccess.c
@@ -109,11 +109,10 @@ acpi_status acpi_ns_root_initialize(void)
new_node->descriptor_type = ACPI_DESC_TYPE_NAMED;
new_node->type = init_val->type;

- if (!prev_node) {
+ if (!prev_node)
acpi_gbl_root_node_struct.child = new_node;
- } else {
+ else
prev_node->peer = new_node;
- }

new_node->parent = &acpi_gbl_root_node_struct;
prev_node = new_node;
--
2.7.4

2019-09-02 21:33:14

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPICA: Namespace: fix the no brace needed warning

On Sat, Aug 31, 2019 at 10:34 AM tiantao <[email protected]> wrote:
>
> for if else statements having single block no braces are needed fixed
> the following checkpatch warning
>
> WARNING: braces {} are not necessary for any arm of this statement
> + if (!prev_node) {
> [...]
> + } else {
> [...]
>
> Signed-off-by: tiantao <[email protected]>
> ---
> drivers/acpi/acpica/nsaccess.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/acpica/nsaccess.c b/drivers/acpi/acpica/nsaccess.c
> index 2566e2d..7cef22a 100644
> --- a/drivers/acpi/acpica/nsaccess.c
> +++ b/drivers/acpi/acpica/nsaccess.c
> @@ -109,11 +109,10 @@ acpi_status acpi_ns_root_initialize(void)
> new_node->descriptor_type = ACPI_DESC_TYPE_NAMED;
> new_node->type = init_val->type;
>
> - if (!prev_node) {
> + if (!prev_node)
> acpi_gbl_root_node_struct.child = new_node;
> - } else {
> + else
> prev_node->peer = new_node;
> - }
>
> new_node->parent = &acpi_gbl_root_node_struct;
> prev_node = new_node;
> --

The ACPICA code comes from an external project and the coding style in
it is different from the rest of the kernel, so the patch is not
applicable.

Thanks!