On Thu, Sep 29, 2016 at 02:38:04AM +0200, Rafael J. Wysocki wrote:
> +static int device_reorder_to_tail(struct device *dev, void *not_used)
> +{
> + struct device_link *link;
> +
> + /*
> + * Devices that have not been registered yet will be put to the ends
> + * of the lists during the registratio, so skip them here.
^
n
> + if (device_is_registered(dev))
> + devices_kset_move_last(dev);
> +
> + if (device_pm_initialized(dev))
> + device_pm_move_last(dev);
Clever solution to this problem. So little code!
> +/**
> + * device_links_check_suppliers - Check presence of supplier drivers.
> + * @dev: Consumer device.
> + *
> + * Check links from this device to any suppliers. Walk the list of the device's
> + * consumer links and see if all of the suppliers are available. If not, simply
^^^^^^^^
"supplier links and see if all if them are available."
> +/*
> + * Device link flags.
> + *
> + * STATELESS: The core won't track the presence of supplier/consumer drivers.
> + * AUTOREMOVE: Remove this link automatically on cunsumer driver unbind.
^
o
Apart from these nits patch [2/5] LGTM, so FWIW:
Reviewed-by: Lukas Wunner <[email protected]>
Thanks,
Lukas
On Sat, Oct 1, 2016 at 9:43 AM, Lukas Wunner <[email protected]> wrote:
> On Thu, Sep 29, 2016 at 02:38:04AM +0200, Rafael J. Wysocki wrote:
>> +static int device_reorder_to_tail(struct device *dev, void *not_used)
>> +{
>> + struct device_link *link;
>> +
>> + /*
>> + * Devices that have not been registered yet will be put to the ends
>> + * of the lists during the registratio, so skip them here.
> ^
> n
>
>> + if (device_is_registered(dev))
>> + devices_kset_move_last(dev);
>> +
>> + if (device_pm_initialized(dev))
>> + device_pm_move_last(dev);
>
> Clever solution to this problem. So little code!
>
>
>> +/**
>> + * device_links_check_suppliers - Check presence of supplier drivers.
>> + * @dev: Consumer device.
>> + *
>> + * Check links from this device to any suppliers. Walk the list of the device's
>> + * consumer links and see if all of the suppliers are available. If not, simply
> ^^^^^^^^
> "supplier links and see if all if them are available."
>
>
>> +/*
>> + * Device link flags.
>> + *
>> + * STATELESS: The core won't track the presence of supplier/consumer drivers.
>> + * AUTOREMOVE: Remove this link automatically on cunsumer driver unbind.
> ^
> o
>
>
> Apart from these nits patch [2/5] LGTM, so FWIW:
>
> Reviewed-by: Lukas Wunner <[email protected]>
Thanks for the review, much appreciated!
Cheers,
Rafael