Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.
It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.
Signed-off-by: Jean Delvare <[email protected]>
Cc: Talel Shenhar <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Daniel Lezcano <[email protected]>
---
drivers/thermal/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-5.18.orig/drivers/thermal/Kconfig 2022-05-22 21:52:31.000000000 +0200
+++ linux-5.18/drivers/thermal/Kconfig 2022-07-31 13:51:55.009394318 +0200
@@ -221,7 +221,7 @@ config THERMAL_EMULATION
config THERMAL_MMIO
tristate "Generic Thermal MMIO driver"
- depends on OF || COMPILE_TEST
+ depends on OF
depends on HAS_IOMEM
help
This option enables the generic thermal MMIO driver that will use
@@ -496,7 +496,7 @@ config SPRD_THERMAL
config KHADAS_MCU_FAN_THERMAL
tristate "Khadas MCU controller FAN cooling support"
- depends on OF || COMPILE_TEST
+ depends on OF
depends on MFD_KHADAS_MCU
select MFD_CORE
select REGMAP
--
Jean Delvare
SUSE L3 Support
On Sun, Jul 31, 2022 at 2:13 PM Jean Delvare <[email protected]> wrote:
>
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
>
> Signed-off-by: Jean Delvare <[email protected]>
> Cc: Talel Shenhar <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Daniel Lezcano <[email protected]>
Daniel, I can pick up this one if that's OK. Any concerns?
> ---
> drivers/thermal/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-5.18.orig/drivers/thermal/Kconfig 2022-05-22 21:52:31.000000000 +0200
> +++ linux-5.18/drivers/thermal/Kconfig 2022-07-31 13:51:55.009394318 +0200
> @@ -221,7 +221,7 @@ config THERMAL_EMULATION
>
> config THERMAL_MMIO
> tristate "Generic Thermal MMIO driver"
> - depends on OF || COMPILE_TEST
> + depends on OF
> depends on HAS_IOMEM
> help
> This option enables the generic thermal MMIO driver that will use
> @@ -496,7 +496,7 @@ config SPRD_THERMAL
>
> config KHADAS_MCU_FAN_THERMAL
> tristate "Khadas MCU controller FAN cooling support"
> - depends on OF || COMPILE_TEST
> + depends on OF
> depends on MFD_KHADAS_MCU
> select MFD_CORE
> select REGMAP
>
> --
> Jean Delvare
> SUSE L3 Support
On 03/08/2022 19:05, Rafael J. Wysocki wrote:
> On Sun, Jul 31, 2022 at 2:13 PM Jean Delvare <[email protected]> wrote:
>>
>> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
>> is possible to test-build any driver which depends on OF on any
>> architecture by explicitly selecting OF. Therefore depending on
>> COMPILE_TEST as an alternative is no longer needed.
>>
>> It is actually better to always build such drivers with OF enabled,
>> so that the test builds are closer to how each driver will actually be
>> built on its intended target. Building them without OF may not test
>> much as the compiler will optimize out potentially large parts of the
>> code. In the worst case, this could even pop false positive warnings.
>> Dropping COMPILE_TEST here improves the quality of our testing and
>> avoids wasting time on non-existent issues.
>>
>> Signed-off-by: Jean Delvare <[email protected]>
>> Cc: Talel Shenhar <[email protected]>
>> Cc: Neil Armstrong <[email protected]>
>> Cc: "Rafael J. Wysocki" <[email protected]>
>> Cc: Daniel Lezcano <[email protected]>
>
> Daniel, I can pick up this one if that's OK. Any concerns?
No concerns, I'm fine with it
Thanks
>> ---
>> drivers/thermal/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> --- linux-5.18.orig/drivers/thermal/Kconfig 2022-05-22 21:52:31.000000000 +0200
>> +++ linux-5.18/drivers/thermal/Kconfig 2022-07-31 13:51:55.009394318 +0200
>> @@ -221,7 +221,7 @@ config THERMAL_EMULATION
>>
>> config THERMAL_MMIO
>> tristate "Generic Thermal MMIO driver"
>> - depends on OF || COMPILE_TEST
>> + depends on OF
>> depends on HAS_IOMEM
>> help
>> This option enables the generic thermal MMIO driver that will use
>> @@ -496,7 +496,7 @@ config SPRD_THERMAL
>>
>> config KHADAS_MCU_FAN_THERMAL
>> tristate "Khadas MCU controller FAN cooling support"
>> - depends on OF || COMPILE_TEST
>> + depends on OF
>> depends on MFD_KHADAS_MCU
>> select MFD_CORE
>> select REGMAP
>>
>> --
>> Jean Delvare
>> SUSE L3 Support
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
On Wed, Aug 3, 2022 at 7:08 PM Daniel Lezcano <[email protected]> wrote:
>
> On 03/08/2022 19:05, Rafael J. Wysocki wrote:
> > On Sun, Jul 31, 2022 at 2:13 PM Jean Delvare <[email protected]> wrote:
> >>
> >> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> >> is possible to test-build any driver which depends on OF on any
> >> architecture by explicitly selecting OF. Therefore depending on
> >> COMPILE_TEST as an alternative is no longer needed.
> >>
> >> It is actually better to always build such drivers with OF enabled,
> >> so that the test builds are closer to how each driver will actually be
> >> built on its intended target. Building them without OF may not test
> >> much as the compiler will optimize out potentially large parts of the
> >> code. In the worst case, this could even pop false positive warnings.
> >> Dropping COMPILE_TEST here improves the quality of our testing and
> >> avoids wasting time on non-existent issues.
> >>
> >> Signed-off-by: Jean Delvare <[email protected]>
> >> Cc: Talel Shenhar <[email protected]>
> >> Cc: Neil Armstrong <[email protected]>
> >> Cc: "Rafael J. Wysocki" <[email protected]>
> >> Cc: Daniel Lezcano <[email protected]>
> >
> > Daniel, I can pick up this one if that's OK. Any concerns?
>
> No concerns, I'm fine with it
OK, applied, thanks!
> >> ---
> >> drivers/thermal/Kconfig | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> --- linux-5.18.orig/drivers/thermal/Kconfig 2022-05-22 21:52:31.000000000 +0200
> >> +++ linux-5.18/drivers/thermal/Kconfig 2022-07-31 13:51:55.009394318 +0200
> >> @@ -221,7 +221,7 @@ config THERMAL_EMULATION
> >>
> >> config THERMAL_MMIO
> >> tristate "Generic Thermal MMIO driver"
> >> - depends on OF || COMPILE_TEST
> >> + depends on OF
> >> depends on HAS_IOMEM
> >> help
> >> This option enables the generic thermal MMIO driver that will use
> >> @@ -496,7 +496,7 @@ config SPRD_THERMAL
> >>
> >> config KHADAS_MCU_FAN_THERMAL
> >> tristate "Khadas MCU controller FAN cooling support"
> >> - depends on OF || COMPILE_TEST
> >> + depends on OF
> >> depends on MFD_KHADAS_MCU
> >> select MFD_CORE
> >> select REGMAP
> >>
> >> --
> >> Jean Delvare
> >> SUSE L3 Support
>
>
> --
> <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>
> Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog